Skip to content

Web: run integration tests as part of our product builds #83923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bpasero opened this issue Nov 4, 2019 · 3 comments
Closed

Web: run integration tests as part of our product builds #83923

bpasero opened this issue Nov 4, 2019 · 3 comments
Assignees
@bpasero @Tyriar
Labels
engineering VS Code - Build / issue tracking / etc. integration-test-failure web Issues related to running VSCode in the web
Milestone
February 2020

Comments

@bpasero
Copy link
Member

bpasero commented Nov 4, 2019

Similar to #80308, would be great if our extension API tests could run against web as part of our product builds.
@bpasero bpasero added debt Code quality issues engineering VS Code - Build / issue tracking / etc. web Issues related to running VSCode in the web labels Nov 4, 2019
@bpasero bpasero added this to the November 2019 milestone Nov 4, 2019
@bpasero bpasero added integration-test-failure and removed debt Code quality issues labels Nov 4, 2019
@Tyriar Tyriar modified the milestones: November 2019, December 2019 Dec 2, 2019
@Tyriar Tyriar modified the milestones: January 2020, February 2020 Jan 27, 2020
@bpasero bpasero assigned bpasero and unassigned bpasero Jan 28, 2020
@bpasero
Copy link
Member Author

bpasero commented Feb 3, 2020

I think this could be challenging to implement to be fair. I just verified that I can indeed run the API tests out of web by having VSCode for web opened on our source repo and then running the tests out of the debug viewlet. However, what is missing would be a way to run these tests directly, e.g. through a direct URL while still capturing all the output.

@bpasero
Copy link
Member Author

bpasero commented Feb 3, 2020

Discussed in the standup today that we should get this going. Similar, our unit tests should run in browser as well.

//cc @jrieken

@bpasero bpasero mentioned this issue Feb 8, 2020
Closed
@bpasero
Copy link
Member Author

bpasero commented Feb 10, 2020

Added via https://github.com/microsoft/vscode/blob/master/test/integration/browser/README.md#run-inside-browser

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 26, 2020
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@bpasero
Web: run integration tests as part of our product builds (fix microso…
127db4d 
…ft#83923)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@Tyriar Tyriar

Labels
engineering VS Code - Build / issue tracking / etc. integration-test-failure web Issues related to running VSCode in the web
Projects
None yet
Milestone
February 2020
Development

Successfully merging a pull request may close this issue.

Web: run integration tests as part of our product builds microsoft/vscode
2 participants
@bpasero @Tyriar