Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Smoke Test: Run against produced build #80308

Closed
bpasero opened this issue Sep 4, 2019 · 2 comments · Fixed by #83799
Closed

Web Smoke Test: Run against produced build #80308

bpasero opened this issue Sep 4, 2019 · 2 comments · Fixed by #83799
Assignees
Labels
engineering VS Code - Build / issue tracking / etc. smoke-test-failure web Issues related to running VSCode in the web
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Sep 4, 2019

All my recent changes to let the integration tests run against the real produced build have lead to the web smoke tests now failing because we are assuming compilation artifacts in ./out while they are in ./out-build on the server. The smoke tests were lucky because previously the integration tests would trigger a full compile.

Instead of fixing this the wrong way, I strongly suggest to change the web smoke tests to:

  • run against the actual web client bits that are being produced
  • using the actual server that is being produced

You can see how we figure out the location of both client and server:

For now I will disable the smoke tests until we have this resolved.

//cc @aeschli

@bpasero
Copy link
Member Author

bpasero commented Oct 31, 2019

@Tyriar at the very minimum - if we are not running this as part of the build - can you make sure we document how to run this smoke test as part of our endgame smoke test run?

@bpasero bpasero added engineering VS Code - Build / issue tracking / etc. and removed broken-build debt Code quality issues labels Nov 4, 2019
@bpasero bpasero self-assigned this Feb 3, 2020
@bpasero bpasero modified the milestones: Backlog, February 2020 Feb 3, 2020
bpasero added a commit that referenced this issue Feb 3, 2020
* Run web against actual server

Part of #80308

* Fix strict null check errors

* Fix folder arg

* Disable unit tests and integration tests temporarily

* Allow running on node 12

* Fix smoke test condition

* Disable continue on error

* Add web to server dir

* fix smoke test to use build for web

* enable in product build

Co-authored-by: Benjamin Pasero <[email protected]>
@bpasero
Copy link
Member Author

bpasero commented Feb 3, 2020

After a few follow up fixes today, here is a test run of web smoke tests with the real build: https://monacotools.visualstudio.com/Monaco/_build/results?buildId=66251&view=logs&j=a5e52b91-c83f-5429-4a68-c246fc63a4f7&t=8e2e103d-8d5d-54da-dc73-3c44bf1dc402

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc. smoke-test-failure web Issues related to running VSCode in the web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants