Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SASS Modules (@forward and @use) #81943

Closed
wongjn opened this issue Oct 4, 2019 · 6 comments
Closed

SASS Modules (@forward and @use) #81943

wongjn opened this issue Oct 4, 2019 · 6 comments
Assignees
@octref
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality grammar Syntax highlighting grammar on-testplan upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone
November 2019

Comments

@wongjn
Copy link

wongjn commented Oct 4, 2019

Dart Sass 1.23.0 dropped recently and with it, a new module system.
It would be great if this was added into the language features for SCSS/SASS.

Documentation pages for each of the new at-rules:
@octref octref added css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality labels Oct 4, 2019
@octref octref added this to the Backlog milestone Oct 4, 2019
@MikeJerred MikeJerred mentioned this issue Oct 9, 2019
Closed
@jathak jathak mentioned this issue Oct 9, 2019
Closed
@wongjn wongjn mentioned this issue Oct 9, 2019
Merged
@wongjn
Copy link
Author

wongjn commented Oct 11, 2019

I've made an extension that adds highlighting in SCSS until this gets added to core.

@wongjn wongjn mentioned this issue Oct 13, 2019
Merged
@octref octref added the upstream-issue-linked This is an upstream issue that has been reported upstream label Oct 17, 2019
@octref
Copy link
Contributor

octref commented Oct 17, 2019

Pending merge on atom/language-sass#269. I'll watch that PR. Thanks @wongjn for your work 👍

@octref octref added the upstream-issue-fixed The underlying upstream issue has been fixed label Nov 12, 2019
@octref octref modified the milestones: Backlog, November 2019 Nov 12, 2019
@octref octref closed this as completed in cf8d61e Nov 12, 2019
@octref
Copy link
Contributor

octref commented Nov 12, 2019

@alexr00 FYI — The upstream change is in. I pulled in the grammars.

@wongjn
Copy link
Author

wongjn commented Nov 12, 2019

I'm wondering if this can actually be closed; there is still the need to update the SCSS parser to understand the new syntax via microsoft/vscode-css-languageservice#183.

@octref octref added the grammar Syntax highlighting grammar label Nov 12, 2019
@octref
Copy link
Contributor

octref commented Nov 12, 2019

OK, I'll keep it open until I have time to review that PR.

@octref octref reopened this Nov 12, 2019
@octref
Copy link
Contributor

octref commented Nov 26, 2019

Thanks to the great work of @wongjn, now we have both syntax highlighting and language server support for SCSS modules.

@octref octref closed this as completed Nov 26, 2019
@kieferrm kieferrm mentioned this issue Dec 2, 2019
Closed
68 tasks
This was referenced Dec 2, 2019
Closed
Closed
Closed
@MattMcAdams MattMcAdams mentioned this issue Dec 5, 2019
Closed
octref added a commit to microsoft/vscode-docs that referenced this issue Dec 6, 2019
@octref
Gif for sass module support. For microsoft/vscode#81943
be02478
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality grammar Syntax highlighting grammar on-testplan upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
2 participants
@octref @wongjn