SASS Modules (@use and @forward)

[wongjn]

Description of the Change

Dart Sass 1.23.0 dropped recently and with it, a new module system.

This pull request adds grammar for:

• @use
• @forward
• module.$variables
• module.functions()
• @include module.includes()

Benefits

Keeps the syntax highlighting for SASS and SCSS files relevant.

Applicable Issues

• Motivated from SASS Modules (@forward and @use) microsoft/vscode#81943 since they seem to use the grammar files here.
• Closes Support for New @use and @forward syntax #270

[rsese]

Thank you! We can't promise a specific timeframe for review but someone from the team will take a look as soon as they can.

[jquense]

🙏

[darangi]

Hi @wongjn, I am currently testing this PR. I used the sample snippets and I got correct scopes for all except module.functions(), I get different scopes when I test it on sass and scss files. I attached some screenshots. Can you please verify this?

*SASS

*SCSS

[wongjn]

I must have overlooked the syntax there; that's now added with tests, but only for property value context.

This is because this follows the existing grammar syntax, which I feel may need a refactor to be more inline with the scss grammar. Wasn't there an issue about this?

[darangi]

@wongjn Thanks for the update, could you point me to that particular issue?

[wongjn]

Sorry, I mean that as an actual question, not a rhetorical one! I couldn't find the issue — I may be confusing it with an issue in a different Sass-related repository.

[darangi]

Alright. Thanks