Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto search - option to search while typing #46326

Closed
liesislukas opened this issue Mar 22, 2018 · 9 comments · Fixed by #84004
Closed

Auto search - option to search while typing #46326

liesislukas opened this issue Mar 22, 2018 · 9 comments · Fixed by #84004
Assignees
Labels
feature-request Request for new features or functionality on-testplan search Search widget and operation issues
Milestone

Comments

@liesislukas
Copy link

  • VSCode Version: Version 1.21.1 (1.21.1)
  • OS Version: macOS 10.13.3 (17D102)

Steps to Reproduce:

  1. open workspace
  2. type something in search - it will not execute search till click of Return/Enter or mouse click

Does this issue occur when all extensions are disabled?: Yes

While for some workspaces with tens of thousands of files it would be performance killer for smaller workspaces I would like to have the option to search "live". When I don't know the exact name of the file I could just start typing and search would make it's job.

@vscodebot vscodebot bot added the search Search widget and operation issues label Mar 22, 2018
@hexnaught
Copy link

If implemented, could it be toggled with a workspace setting and defaulted to 'False' ?

I agree that it could be a nice feature for smaller workspaces.

@liesislukas
Copy link
Author

liesislukas commented Mar 22, 2018

in settings :

search.autoSearch = auto | afterDelay | off

auto = turn autoSearch to afterDelay if project has <10000 files. Not sure how many files are considered as many for this algorithm. Probably file size is doing impact too.

afterDelay = auto search when "done" typing
Also search.autoSearchDelay = 300
It would mean: if no character input for 300ms - do the search.

Similar to "files.autoSaveDelay": 300 option, which I don't like that it saves after each keyDown event not when done typing but it's different issue. #46338

off = user has submit search input manually like it is now.

@roblourens roblourens added the feature-request Request for new features or functionality label Mar 22, 2018
@Sco768
Copy link

Sco768 commented May 17, 2018

I feel like we have opposite experience with search:

  1. I open a large file
  2. I start typing in a search field and the file starts scrolling automatically to a match of my incomplete query

This is very distracting, especially when I'm trying to construct a search query based on what I see.
And I don't see a search.autoSearch setting anywhere to turn this off.

@codyfyi
Copy link

codyfyi commented Jun 1, 2018

I've really been longing for this feature after coming over from WebStorm or IntelliJ!

I had no idea how helpful it was until I didn't have it. It can be a life saver to see search results populate live as you type because you often can't remember the full term or there are many similar terms.

I'd love to see live search come to VS Code too!

@jbwyme
Copy link

jbwyme commented Dec 11, 2018

Would love to see this feature as well, it's the biggest reason I'm considering dropping vscode.

https://nuclide.io/blog/2017/08/31/Code-Search/

Additionally, it'd be great if there was an Omnisearch that searches filenames and content

@benmardana
Copy link

This would be great to have. Even after weeks of using vscode I forget that it doesn't autosearch and I will highlight text then do CMD+Shift+F expecting to immediately be shown the results. Hitting the Enter key just doesn't want to get saved in my muscle memory :'(

@mykolav
Copy link

mykolav commented Apr 18, 2019

It would also be great if we could enter the search term into command palette/Quick-Pick's input field and get live results in its list.

Something like this:

image of atom-fuzzy-grep package

@arbaes
Copy link

arbaes commented Sep 5, 2019

Landed here after searching for how to enable this feature. It seems it's finally my turn to drop the classic Any news on this ?

@lucasvazq
Copy link

Any news on this ?

@roblourens roblourens added this to the Backlog milestone Oct 27, 2019
JacksonKearl pushed a commit that referenced this issue Nov 5, 2019
JacksonKearl pushed a commit that referenced this issue Nov 6, 2019
* Make Search All Files search as you type
Closes #46326.

* Fix tests

* Cancel search before queueing a new one.
Reduces background load while user is typing rest of query

* Reduce progress indicator flicker in fast searches

* Don't trigger search on control chars

* Remove ".only" form test

* Remove unused emitter parameter

* Clean up diff

* Delay adding possibly partial search string to histroy

* Clean up diff
@bpasero bpasero modified the milestones: Backlog, November 2019 Nov 7, 2019
@JacksonKearl JacksonKearl mentioned this issue Dec 2, 2019
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan search Search widget and operation issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.