Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Search on Type #85953

Closed
3 tasks done
JacksonKearl opened this issue Dec 2, 2019 · 2 comments
Closed
3 tasks done

Test: Search on Type #85953

JacksonKearl opened this issue Dec 2, 2019 · 2 comments
Labels
testplan-item
Milestone
November 2019

Comments

@JacksonKearl
Copy link
Contributor

JacksonKearl commented Dec 2, 2019 •
edited by sana-ajani
Loading

Refs: #46326

Complexity: 2

Authors: @JacksonKearl

The workspace search now has setting "search.searchOnType" enabled by default, causing results to update as you type, rather than on enter. Please ensure:

  • Edits to any field trigger a search (query, include, exclude, toggling each button)
  • Further typing doesn't feel sluggish after a search has been triggered
  • search.searchOnTypeDebouncePeriod can be configured to:
    • Change the delay between a keystroke and a search being triggered
    • But Enter and toggling buttons still instantly trigger the search.
  • Results shouldn't flicker as searches are re-triggered
@JacksonKearl JacksonKearl added this to the November 2019 milestone Dec 2, 2019
This was referenced Dec 3, 2019
Closed
Closed
@miguelsolorio miguelsolorio removed their assignment Dec 3, 2019
@sbatten sbatten mentioned this issue Dec 3, 2019
Closed
@sbatten sbatten assigned sana-ajani and unassigned sana-ajani and sbatten Dec 3, 2019
@sana-ajani
Copy link
Contributor

Besides a bit of flickering in the search results and in the "X results in Y files" line, this works well! Super neat

@sana-ajani sana-ajani removed their assignment Dec 4, 2019
@JacksonKearl
Copy link
Contributor Author

@sana-ajani @sbatten Increased the delay a bit in 27a00da to try to reduce flickering. We can see if its enough on the next build.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
testplan-item
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
6 participants
@roblourens @jrieken @sbatten @JacksonKearl @sana-ajani @miguelsolorio