Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement multi-root aware file watcher #28947

Closed
7 tasks done
Tyriar opened this issue Jun 17, 2017 · 0 comments
Closed
7 tasks done

Implement multi-root aware file watcher #28947

Tyriar opened this issue Jun 17, 2017 · 0 comments
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality on-testplan workbench-multiroot Multi-root (multiple folders) issues
Milestone
June 2017

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 17, 2017 •
edited
Loading

Plan item: #28344
Feature request #396

TODO

  • Fix module in built package
  • Initialize file watcher with getWorkspace2, not basePath (bugged after reload, until config change)
  • Enable new file watcher when opening in multi-root workspace
  • PR to reduce nsfw size Use individual lodash function modules Axosoft/nsfw#23
  • OSS requests
  • Support files.watcherExcludes
  • Don't want roots that are sub-folders of other roots

Blocked:

  • Pull in new version of nsfw
@Tyriar Tyriar added feature-request Request for new features or functionality workbench-multiroot Multi-root (multiple folders) issues labels Jun 17, 2017
@Tyriar Tyriar added this to the June 2017 milestone Jun 17, 2017
@Tyriar Tyriar self-assigned this Jun 17, 2017
@Tyriar Tyriar mentioned this issue Jun 17, 2017
Merged
@egamma egamma mentioned this issue Jun 17, 2017
Closed
2 tasks
Tyriar added a commit that referenced this issue Jun 19, 2017
@Tyriar
Fix nsfw module packaging problems
d28de6d 
Part of #28947
Tyriar added a commit that referenced this issue Jun 21, 2017
@Tyriar
Disallow file watcher to watch sub-folders of other folders
a5c3f02 
Part of #28947
@Tyriar Tyriar mentioned this issue Jun 22, 2017
Merged
@Tyriar Tyriar closed this as completed Jun 23, 2017
@Tyriar Tyriar mentioned this issue Jun 26, 2017
Closed
41 tasks
This was referenced Jun 28, 2017
Closed
Closed
@mjbvz mjbvz mentioned this issue Nov 3, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality on-testplan workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
2 participants
@roblourens @Tyriar