Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watcher does not pick up changes in webdav directory on windows #29804

Closed
mjbvz opened this issue Jun 28, 2017 · 3 comments
Closed

Watcher does not pick up changes in webdav directory on windows #29804

mjbvz opened this issue Jun 28, 2017 · 3 comments
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality file-watcher File watcher *out-of-scope Posted issue is not in scope of VS Code upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Milestone
Backlog

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 28, 2017 •
edited
Loading

Testing #29478

  • VSCode Version: 1.14-insiders
  • OS Version: Windows 10

Steps to Reproduce:

  1. Open a webdav folder in vscode. For example: https://microsoft.sharepoint.com/teams/DD_OTP/Documents/Java and Open Tools/Node/test. (For that example link, you have to add https://microsoft.sharepoint.com/ to your trusted websites. Try opening that link in IE on corpnet. Let me know if you need help with this step )
  2. Open a file in the webdav folder
  3. In an external program, edit the file and save it

Bug
Changes to the file as not reflected in vscode
@mjbvz mjbvz added file-watcher File watcher windows VS Code on Windows issues labels Jun 28, 2017
@vscodebot vscodebot bot added the insiders label Jun 28, 2017
@mjbvz mjbvz changed the title New watcher does not pick up changes in webdav directory in windows New watcher does not pick up changes in webdav directory on windows Jun 28, 2017
@Tyriar
Copy link
Member

Tyriar commented Jun 28, 2017

@bpasero would this be a new feature?

@mjbvz
Copy link
Collaborator Author

mjbvz commented Jun 28, 2017

Yes, from a quick test it looks like we also did not support webdav folders 1.13 with the old watcher

@mjbvz mjbvz changed the title New watcher does not pick up changes in webdav directory on windows Watcher does not pick up changes in webdav directory on windows Jun 28, 2017
@Tyriar Tyriar added the feature-request Request for new features or functionality label Jun 29, 2017
@Tyriar Tyriar added this to the Backlog milestone Jun 29, 2017
@Tyriar Tyriar removed the insiders label Jun 29, 2017
@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Sep 11, 2018
@Tyriar Tyriar added the *out-of-scope Posted issue is not in scope of VS Code label Sep 12, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 12, 2018

This iteration we focus on issue grooming. This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Sep 12, 2018
mofojed added a commit to mofojed/web-client-ui that referenced this issue Jun 22, 2021
@mofojed
Show the notebooks directory contents in a basic format in the FileEx…
d922f09 
…plorer panel

Gotta make it an actual list
How to listen for changes? Polling?
VSCode had an issue not listening for changes here: microsoft/vscode#29804

Maybe poll every 60s or something, and otherwise just listen for any local user events that could change the name of a file.
mofojed added a commit to deephaven/web-client-ui that referenced this issue Jun 25, 2021
@mofojed
Webdav example. CORS getting in the way
086a84d 
Fix up paths and query

Add the file explorer component

Show the notebooks directory contents in a basic format in the FileExplorer panel

Gotta make it an actual list
How to listen for changes? Polling?
VSCode had an issue not listening for changes here: microsoft/vscode#29804

Maybe poll every 60s or something, and otherwise just listen for any local user events that could change the name of a file.

WIP Add FileExplorerToolbar

Got the WebdavExplorer working for showing the root list, need to make it react to click, create new files, etc

Open file

It will open the file, but doesn't actually load the contents yet.

TODO:
- Load file contents
- Icons for items in the list
- Directory support

Load file

Now you can click on a file, and it will open and you can run the file

Enable saving a file

WIP  Rename to file-explorer

Working on WebdavTileStorageTable

Change WebdavFileExplorer => FileExplorer, implement WebdavFileStorage

Makes FileExplorer more re-usable with other types of storage

WIP adding back save as functionality

Need to re-import the NewItemModal, and abstract it to just use FileStorage (right now it has some dependencies on TreeTables, etc).

WIP adding the NewItemModal back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality file-watcher File watcher *out-of-scope Posted issue is not in scope of VS Code upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@bpasero @Tyriar @mjbvz