-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal should advertise "Simple Browser" #200579
Comments
Doing this would be a matter of registering a terminal link provider in the simple-browser extension: vscode/src/vscode-dts/vscode.d.ts Line 11049 in 83180a3
|
Oh nice! I might take a look. |
Having played with this API for 5 minutes, here is some feedback: for one, there does not seem to be a related extension activation mechanism for detecting links, forcing me to But more importantly: it seems that I am taking over the entire handling of the link, even in presence of our default handler to open in the external web browser. I am not sure what I would expect, but my goal was just to give a hint that the link can optionally be opened in the simple browser as well, just as a way to make it discoverable in this case. |
Yes I don't think there's an activation event, I don't think it's come up yet as GitLens and GHPRI are the main use cases. For the default handler, this is currently handled within the extension itself. The hope was to eventually support multiple link handlers but was closed last year: #97070 |
This feature would also be very interesting for the edge dev tools extension (marketplace link). |
We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our roadmap and issue reporting guidelines. Thanks for your understanding, and happy coding! |
With a link such as:
Would be great to offer to open it in our "Simple Browser" editor:
The text was updated successfully, but these errors were encountered: