Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal should advertise "Simple Browser" #200579

Closed
bpasero opened this issue Dec 11, 2023 · 6 comments
Closed

Terminal should advertise "Simple Browser" #200579

bpasero opened this issue Dec 11, 2023 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities *out-of-scope Posted issue is not in scope of VS Code terminal-links
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Dec 11, 2023

With a link such as:

image

Would be great to offer to open it in our "Simple Browser" editor:

image
@Tyriar Tyriar added feature-request Request for new features or functionality terminal-links labels Dec 11, 2023
@Tyriar Tyriar added this to the Backlog milestone Dec 11, 2023
@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Dec 11, 2023
@Tyriar
Copy link
Member

Tyriar commented Dec 11, 2023

Doing this would be a matter of registering a terminal link provider in the simple-browser extension:

export function registerTerminalLinkProvider(provider: TerminalLinkProvider): Disposable;

@bpasero
Copy link
Member Author

bpasero commented Dec 11, 2023

Oh nice! I might take a look.

@bpasero
Copy link
Member Author

bpasero commented Dec 12, 2023

Having played with this API for 5 minutes, here is some feedback: for one, there does not seem to be a related extension activation mechanism for detecting links, forcing me to *-activate the simple browser extension.

But more importantly: it seems that I am taking over the entire handling of the link, even in presence of our default handler to open in the external web browser. I am not sure what I would expect, but my goal was just to give a hint that the link can optionally be opened in the simple browser as well, just as a way to make it discoverable in this case.

@Tyriar
Copy link
Member

Tyriar commented Dec 12, 2023

Yes I don't think there's an activation event, I don't think it's come up yet as GitLens and GHPRI are the main use cases.

For the default handler, this is currently handled within the extension itself. The hope was to eventually support multiple link handlers but was closed last year: #97070

@hediet
Copy link
Member

hediet commented Dec 13, 2023

This feature would also be very interesting for the edge dev tools extension (marketplace link).

Copy link

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@vs-code-engineering vs-code-engineering bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities *out-of-scope Posted issue is not in scope of VS Code terminal-links
Projects
None yet
Development

No branches or pull requests

3 participants