Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Terminal Link Handler #1893

Open
hediet opened this issue Dec 13, 2023 · 1 comment
Open

Implement Terminal Link Handler #1893

hediet opened this issue Dec 13, 2023 · 1 comment
Labels
enhancement New feature or request tracked

Comments

@hediet
Copy link
Member

hediet commented Dec 13, 2023

Very often, the terminal is used to spawn a dev http server (nextjs and webpack do this):

Image

It would be nice if the edge webview would open when clicking on the url.
Extensions can override the link click behavior by using registerTerminalLinkProvider.
However, I suggest to not do this by default, until microsoft/vscode#200579 lands: Rather, VS Code should ask the user if they want to use the OS browser or edge dev tools or the simple browser that ships with VS Code.

For now, the extension could add a setting that would control if it registers a terminal link provider.
This optional feature would then push us to implement microsoft/vscode#200579.

@captainbrosset
Copy link
Collaborator

Thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tracked
Projects
None yet
Development

No branches or pull requests

2 participants