Recent change to link detection in the terminal is a regression

[jribbens]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.75.1
• OS Version: Windows 11

Steps to Reproduce:

1. Display a link in the terminal of the form https://example.com/path(abc,def)
2. Previously the link would be automatically detected correctly and made clickable (although in the debug tab, by contrast, it was not detected properly).
3. Since version 1.75.0, the link detection wrongly terminates at the , so the link cannot be easily clicked to open it.

I appreciate that you can never please all the people all the time with URL guessing, but I thought it was worth mentioning given that it used to work fine, and to be fair all the characters (, , and ) are standard normal URL code points and always have been.

[Tyriar]

Can repro after, not before:

[Tyriar]

This is actually a regression in monaco's link detection which the terminal leverages for uris:

1.74:

1.75:

So this was unrelated to the recent terminal link improvements which focused on file detection

[hediet]

This PR introduced this change to fix this issue

[Tyriar]

Commas are used pretty often in certain links, not sure how advanced the detection is but it could be improved by only treating it as a separator if after a / or if the word before has a period?

[hediet]

GitHub also doesn't split at comma:
https://github.com/microsoft/vscode,https://github.com/microsoft/vscode

I'd probably revert the fix, but I'm fine with either. Up to you @alexdima.

[Ruler90]

This issue doesn't just affect the links in the terminal. It also applies to .js, .ts and .md files (and maybe more).

VS Code Version: 1.75.1
OS Version: Windows 10

Steps to reproduce:

1. Create a .js file and paste the following code into it:
   const url = "https://www.empik.com/samsung-galaxy-sm-s918bzedeuedm3-8-gb-ram-256-gb-bezowy-samsung,p1360111382,elektronika-p";
2. Create an .md file and paste the following url into it:
   https://www.empik.com/samsung-galaxy-sm-s918bzedeuedm3-8-gb-ram-256-gb-bezowy-samsung,p1360111382,elektronika-p.
3. In both cases the link detection wrongly terminates at the , so the link cannot be easily clicked to open it.

[alexdima]

👍 I'm OK to revert.