Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLs in CSV document not split by field #119696

Closed
thaliaarchi opened this issue Mar 23, 2021 · 0 comments · Fixed by #168752
Closed

URLs in CSV document not split by field #119696

thaliaarchi opened this issue Mar 23, 2021 · 0 comments · Fixed by #168752
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug editor-contrib Editor collection of extras insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
January 2023

Comments

@thaliaarchi
Copy link

thaliaarchi commented Mar 23, 2021 •
edited
Loading

Issue Type: Bug

When editing a CSV document, automatically-detected URLs (aka option+click to open) are often conjoined with the start of the following field. I presume the URL detection heuristic for plain text documents is reused for CSV documents. I propose that URLs are automatically closed on a comma.

Here is an example:

https://apod.nasa.gov/apod/ap170720.html,IC 1396: Emission Nebula in Cepheus,https://apod.nasa.gov/apod/image/1707/MOSAIC_IC1396_HaSHO_blanco1024.jpg,https://apod.nasa.gov/apod/image/1707/MOSAIC_IC1396_HaSHO_blanco.jpg
https://apod.nasa.gov/apod/ap180402.html,"Moons, Rings, Shadows, Clouds: Saturn (Cassini)",https://apod.nasa.gov/apod/image/1804/SaturnRingsMoons_Cassini_967.jpg,https://apod.nasa.gov/apod/image/1804/SaturnRingsMoons_Cassini_967.jpg

These are the URLs as currently delimited (only 1 is correct):

  • https://apod.nasa.gov/apod/ap170720.html,IC
  • https://apod.nasa.gov/apod/ap180402.html
  • https://apod.nasa.gov/apod/image/1707/MOSAIC_IC1396_HaSHO_blanco1024.jpg,https://apod.nasa.gov/apod/image/1707/MOSAIC_IC1396_HaSHO_blanco.jpg
  • https://apod.nasa.gov/apod/image/1804/SaturnRingsMoons_Cassini_967.jpg,https://apod.nasa.gov/apod/image/1804/SaturnRingsMoons_Cassini_967.jpg

VS Code version: Code 1.54.3 (2b9aebd, 2021-03-15T11:57:12.728Z)
OS version: Darwin x64 18.7.0
@aeschli aeschli assigned alexdima and unassigned aeschli Mar 24, 2021
@alexdima alexdima added editor-contrib Editor collection of extras bug Issue identified by VS Code Team member as probable bug labels Mar 24, 2021
@alexdima alexdima added this to the January 2023 milestone Dec 10, 2022
@alexdima alexdima mentioned this issue Dec 10, 2022
Merged
alexdima added a commit that referenced this issue Dec 10, 2022
@alexdima
Fixes #119696: Treat commas as link terminators
e971170
alexdima added a commit that referenced this issue Dec 11, 2022
@alexdima
Treat commas as link terminators (#168752)
f730897 
Fixes #119696: Treat commas as link terminators
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 11, 2022
@andreamah andreamah added the verified Verification succeeded label Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug editor-contrib Editor collection of extras insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

Treat commas as link terminators microsoft/vscode
5 participants
@alexdima @aeschli @thaliaarchi @andreamah @vscodenpa