Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA is not recognized on Windows After Reload Of VS Code #167583

Closed
hediet opened this issue Nov 29, 2022 · 4 comments · Fixed by #168246
Closed

NVDA is not recognized on Windows After Reload Of VS Code #167583

hediet opened this issue Nov 29, 2022 · 4 comments · Fixed by #168246
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug chromium Issues and items related to Chromium insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@hediet
Copy link
Member

hediet commented Nov 29, 2022

Testing #167159

Steps:

  • Start NVDA
  • Start VS Code Insiders
  • Screen reader is detected.
  • Reload VS Code
  • Screen reader is not detected anymore.
@isidorn
Copy link
Contributor

isidorn commented Nov 29, 2022

@hediet does it work for you if you try with VS Code stable?

@hediet hediet changed the title NVDA is not recognized on Windows NVDA is not recognized on Windows After Reload Of VS Code Nov 29, 2022
@hediet
Copy link
Member Author

hediet commented Nov 29, 2022

Updated steps. Stable has the same issue.
It works if not reloading VS Code.

@deepak1556
Copy link
Collaborator

@isidorn the runtime will emit the a11y event when there is a change triggered by assistive technologies connection to the runtime. So for the reload scenario the application instance already got the event before reload that it has entered a11y mode, after reload the application should query the runtime to determine the current status, for ex: calling https://github.com/electron/electron/blob/main/docs/api/app.md#appisaccessibilitysupportenabled-macos-windows.

@deepak1556 deepak1556 added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Nov 29, 2022
@isidorn
Copy link
Contributor

isidorn commented Nov 30, 2022

@deepak1556 thanks. Sounds like a bug in the https://github.com/microsoft/vscode/blob/main/src/vs/workbench/services/accessibility/electron-sandbox/accessibilityService.ts#L30
So accessibilityService should make sure to ask Electron if accessibilitySupport is enabled on start. I just tried and I can also reproduce this issue on macOS.

@meganrogge is this something you might be interested for next milestone?
fyi @sbatten as the original author of accessibilityService

Assigning to next milestone since this feels low hanging and high impact

@isidorn isidorn added this to the December 2022 milestone Nov 30, 2022
@isidorn isidorn assigned meganrogge and unassigned deepak1556 and isidorn Dec 1, 2022
meganrogge added a commit that referenced this issue Dec 2, 2022
@meganrogge meganrogge added the chromium Issues and items related to Chromium label Dec 6, 2022
meganrogge added a commit that referenced this issue Dec 6, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 12, 2022
@bhavyaus bhavyaus added the verified Verification succeeded label Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug chromium Issues and items related to Chromium insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants