Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: accessibility detection improvements #167159

Closed
3 tasks done
isidorn opened this issue Nov 24, 2022 · 3 comments
Closed
3 tasks done

Test: accessibility detection improvements #167159

isidorn opened this issue Nov 24, 2022 · 3 comments
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues testplan-item
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Nov 24, 2022

Refs: #162331

Complexity: 3
Authors: @deepak1556 @isidorn

Create Issue


We have improved how we auto detect if a screen reader is on when using VS Code. Now this detection should be more precise. You should verify that the detection still works fine.
If you got Windows install NVDA and JAWS and test both. If you got macOS - just use VoiceOver (Cmd+F5). If you got Linux - use Orca.

  • When starting a Screen Reader with VS Code running, all VS Code windows detect this and the status bar shows "Screen Reader Detected". The editor now begins to output screen reader content to the <textarea>. This is proved by the screen reader reading the text in the editor as the editor cursor moves.
  • Please also check other scenarios, such as first starting the screen reader and then launching VS Code, or reloading a window, or opening a new window, etc. In all cases, the fact that a screen reader is attached should be detected. This is important, because otherwise the editor does not output screen reader content to the <textarea> (which gives us a nice performance boost)
  • Turn off screen reader. Start VS Code again. Make sure the screen reader is not detected (there is no status bar message).
@isidorn isidorn added testplan-item accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Nov 24, 2022
@isidorn isidorn added this to the November 2022 milestone Nov 24, 2022
@ghost ghost assigned kieferrm, hediet and roblourens Nov 29, 2022
@hediet hediet removed their assignment Nov 29, 2022
@kieferrm kieferrm removed their assignment Nov 29, 2022
@kieferrm
Copy link
Member

This doesn't work for me at all. See #167627.

@roblourens
Copy link
Member

It's also not working with Orca. But Daniel suggested that Orca doesn't work well with Electron anyway?

@roblourens roblourens removed their assignment Nov 29, 2022
@aeschli aeschli closed this as completed Nov 30, 2022
@isidorn
Copy link
Contributor Author

isidorn commented Nov 30, 2022

@kieferrm thanks for testing, let's continue the discussion in #167627

@roblourens thanks for trying on Linux. I thought that later Chromium versions detect Orca better and would expect auto detection to work. @joanmarie might you know if latest Chrome versions still require the accessibility flag to be explicitly turned on (i.e they do not detect Orca)? Rob can you file an issue for this so we have this tracked?

fyi @meganrogge

@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues testplan-item
Projects
None yet
Development

No branches or pull requests

5 participants