Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: terminal quick fix telemetry #167475

Closed
3 tasks done
meganrogge opened this issue Nov 28, 2022 · 6 comments
Closed
3 tasks done

test: terminal quick fix telemetry #167475

meganrogge opened this issue Nov 28, 2022 · 6 comments

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Nov 28, 2022

Refs #167473

Complexity: 3

Authors: @meganrogge @Tyriar

Create Issue


Turn on log level: trace and verify that the info for terminal/quick-fix is correct for all of the types of quick fixes we offer:

  • git similar : git sttatus
  • git push : checkout a branch that has no upstream and git push
  • git create PR : git push --set-upstream origin <branch-name>
  • git two dashes: git add . -all
  • free port : launch a server or task that uses a specific <port> then launch that again so you see an error related to address already in use
@meganrogge meganrogge added this to the November 2022 milestone Nov 28, 2022
@ghost ghost assigned weinand, bamurtaugh and rzhao271 Nov 29, 2022
@weinand
Copy link
Contributor

weinand commented Nov 29, 2022

@meganrogge I don't understand what to do here.

@bamurtaugh
Copy link
Member

I'm also not sure what to do here - additional info / examples would be super helpful!

@Tyriar
Copy link
Member

Tyriar commented Nov 29, 2022

Sorry about that. Open up the telemetry log channel as described in https://code.visualstudio.com/docs/getstarted/telemetry#_output-channel-for-telemetry-events, then trigger quick fixes as described in https://code.visualstudio.com/docs/terminal/shell-integration#_quick-fixes. Validate you see events for each of the quick fixes.

@weinand
Copy link
Contributor

weinand commented Nov 29, 2022

@Tyriar thanks, that was helpful.

@rzhao271
Copy link
Contributor

Also, what are some steps I can try to get the free port message to show up?
I don't remember the last time I encountered that scenario.

@Tyriar
Copy link
Member

Tyriar commented Nov 29, 2022

@rzhao271 this is my typical test:

  1. Clone https://github.com/xtermjs/xterm.js
  2. Run yarn
  3. ctrl+shift+b to run default build task (first server)
  4. Open a new terminal and run npm start (conflicting server)

@rzhao271 rzhao271 removed their assignment Nov 29, 2022
@bamurtaugh bamurtaugh removed their assignment Nov 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants