Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: terminal quick fix widget #166761

Closed
4 tasks done
meganrogge opened this issue Nov 18, 2022 · 7 comments
Closed
4 tasks done

Test: terminal quick fix widget #166761

meganrogge opened this issue Nov 18, 2022 · 7 comments

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Nov 18, 2022

Refs #162067

Complexity: 3

Authors: @meganrogge @Tyriar @mjbvz

Create Issue


We now have an ActionWidgetService used by both the code actions in the editor and the quick fixes in the terminal. Make sure that the widget works as expected in the terminal and feels consistent with the experience in an editor.

The quick fixes we support currently include:

  • git similar : git sttatus
  • git push : checkout a branch that has no upstream and git push
  • git create PR : git push --set-upstream origin <branch-name>
  • git two dashes: git add . -all
  • free port : launch a server or task that uses a specific <port> then launch that again so you see an error related to address already in use - example
@sandy081
Copy link
Member

@meganrogge Do you mean this widget in the terminal?

image

Also, I tried to add quick fixes using following contribution and I do not know why I do not see it

"terminal": {
			"quickFixes": [
				{
					"id": "terminal-sample fix",
					"commandLineMatcher": "echo [^\\s]+",
					"outputMatcher": {
						"lineMatcher": "(?<input>[^\\s]+) (?<inputtwo>[^\\s]+)",
						"anchor": "bottom",
						"length": 1,
						"offset": 0
					},
					"linkToOpen": "https://google.com/${group:input}${group:inputtwo}",
				}
			]
		}

Got this sample from here

PS: It would be great, if the description of the test plan item has more context about what is being tested and some samples/references that can be helpful for testing.

@Tyriar
Copy link
Member

Tyriar commented Nov 29, 2022

@sandy081 run git stt for example, you should see a lightbulb that opens a widget like this:

image

See release notes and docs for more examples: https://code.visualstudio.com/updates/v1_72#_terminal-quick-fixes, https://code.visualstudio.com/docs/terminal/shell-integration#_quick-fixes

@meganrogge
Copy link
Contributor Author

meganrogge commented Nov 29, 2022

@sandy081 sorry for the confusion/ lack of directions. we just care about testing the functionality of the quick fix widget in this issue - no need to test the contribution point. I've updated the instructions above.

For example:
Screenshot 2022-11-29 at 2 00 45 PM

@sandy081
Copy link
Member

Thanks for the updated description.

@sandy081 sandy081 removed their assignment Nov 29, 2022
@aeschli aeschli assigned lszomoru and unassigned connor4312 Nov 30, 2022
@lszomoru
Copy link
Member

I am not seeing any decorations in the terminal. Am I missing a setting?
image

@Tyriar
Copy link
Member

Tyriar commented Nov 30, 2022

@lszomoru are you in screen reader mode, do you have the conpty setting overridden and what version of powershell are you on?

@lszomoru
Copy link
Member

It was the conpty setting. Thank you!

@lszomoru lszomoru removed their assignment Nov 30, 2022
@devinvalenciano devinvalenciano removed their assignment Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants