Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AutoDisableAccessibility Chromium runtime flag #162331

Closed
isidorn opened this issue Sep 29, 2022 · 4 comments · Fixed by #167095
Closed

Enable AutoDisableAccessibility Chromium runtime flag #162331

isidorn opened this issue Sep 29, 2022 · 4 comments · Fixed by #167095
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X on-testplan
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Sep 29, 2022

As part of https://bugs.chromium.org/p/chromium/issues/detail?id=1143047 chromium added a runtime feature called AutoDisableAccessibility and it works like this:

Adds logic that disables accessibility under these circumstances:
* There are 3+ user input events in web content (mouse down, key down,
  or touch start count)
* Over a period of more than 30 seconds
* And no usage of accessibility APIs in that time.

The goal of this logic is to avoid disabling accessibility
simply due to inactivity, i.e. the browser is idle - but instead
to try to disable accessibility when there's evidence that the
user is actively using their browser but no longer using assistive
technology or anything else using accessibiltiy APIs.

We should try out this flag to see how it affects our accessibility detection on macOS.

@isidorn isidorn added macos Issues with VS Code on MAC/OS X accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Sep 29, 2022
@isidorn isidorn added this to the October 2022 milestone Sep 29, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 23, 2022
@isidorn
Copy link
Contributor Author

isidorn commented Nov 24, 2022

@deepak1556 thanks a lot for this. Just as a refresh, this only affects macOS?
fyi @devinvalenciano this change might affect our telemetry numbers - since now we might auto disable accessibility when chrome decides it is actually not being needed.

@deepak1556
Copy link
Collaborator

@isidorn I have enabled it for all OS since there is no downside. As part of this, I also redid the accessibility event that gets fired from the runtime to work well with this feature flag. So, in endgame it would be good to have test plan that ensures our accessibility detection continues works fine on all OS.

@isidorn
Copy link
Contributor Author

isidorn commented Nov 24, 2022

@deepak1556 ok, I can create a test plan item for that today with complexity 3.

fyi @meganrogge

@isidorn
Copy link
Contributor Author

isidorn commented Nov 24, 2022

Created test plan item #167159
Feel free to edit it if you think I did not cover some scenario. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X on-testplan
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants