Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light bulb should be greyed out after the line/keybinding is no longer active #167592

Closed
connor4312 opened this issue Nov 29, 2022 · 2 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *not-reproducible Issue cannot be reproduced by VS Code Team member as described terminal-quick-fix verified Verification succeeded
Milestone

Comments

@connor4312
Copy link
Member

Testing #166761

In the editor, users are trained that whenever they see a lightbulb, they can ctrl+. for a quick fix. However, in a terminal, we can show a lightbulb for a previous line:

image

This light bulb can still be clicked on, but the keybinding doesn't work here. I suggest greying out (or removing) the lightbulb in this case.

@mjbvz mjbvz removed their assignment Nov 29, 2022
@Tyriar
Copy link
Member

Tyriar commented Nov 29, 2022

This is a special case where if no command is run, the previous quick fixes are still available, for example if you double hit enter. It's correct that it's yellow but the keybinding should definitely still be working.

@Tyriar Tyriar added this to the December 2022 milestone Nov 29, 2022
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-quick-fix labels Nov 29, 2022
@meganrogge
Copy link
Contributor

The keybinding still works for me even after i've hit enter a few times

@meganrogge meganrogge added the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label Dec 12, 2022
@mjbvz mjbvz added the verified Verification succeeded label Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *not-reproducible Issue cannot be reproduced by VS Code Team member as described terminal-quick-fix verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants