Minimize number of extension query requests to Marketplace

[sandy081]

Minimize number of extension query requests to Marketplace

• At present, one request is made per each installed extension when the latest version of that extension in the marketplace is not compatible. Change it to one request for all such extensions.

• At present, an additional request is made to know if there is a release version or not even when requested for pre-release version. This is to support the feature - not to show install release version button or not to show switch to release version button - Pre-Release only extensions show up in Stable search results #138231. Since this adds additional overhead on MP, lets unsupport this feature and support it when MP moves to SemVer with proper efficient query API.

[sandy081]

Improvements:

• Refactored ExtensionsGalleryService to funnel all workbench Marketplace queries into single queryGalleryExtensions method which can serve all purposes (compatible, target platform, version, pre-release...)
• let workbench make single request (max 2 queries) to query all latest compatible installed extensions while checking for updates. Before there can be more requests if the latest versions are not compatible.
• With introduction of pre-release feature, VS Code added an additional request every time a pre-release extension is found in the query result. This request is to check if the pre-release extension has a release version or not and show the UI (like Install/Switch to Release Version buttons) accordingly. Added a change to remove this additional request completely in VS Code Insiders and also avoids this additional request while fetching updates in both VS Code insiders and stable. NOTE: If in case extension does not have a release version, UI remains same but users will see following error when installing the release version.
  

[sandy081]

cc @SaiKanth007

[SaiKanth007]

I also remember we discussed that having two instances of VSCode editors open will make two different update calls to marketplace, even that is optimized as part of this ?

Is Featured Extension call also included in the above mentioned 2 calls or is it different ?

[sandy081]

I also remember we discussed that having two instances of VSCode editors open will make two different update calls to marketplace, even that is optimized as part of this ?

No, that needs considerable design changes and felt not worth the change. Current optimizations listed above are already good enough.