Opening a new window shows a prompt that GitHub extension cannot be activated

[sandy081]

Steps to Reproduce:

1. Open a new window. Following prompt is shown

[sandy081]

This is because Git extension is disabled because of workspace trust and GitHub extension is enabled (as it supported). Actual fix is to disable GitHub extension which will be taken care here - #122448.

Did a pragmatic fix here:

• Fixed the prompt in this case by providing appropriate message and no actions are shown.

• In order to provide better experience OOB ie., not to show these error prompts, made GitHub extension to not to support untrusted workspaces as its dependency Git extensions does not. It means that above prompt is not shown OOB.

[lszomoru]

@sandy081, in case that we detect that the dependency is not loaded due to workspace trust, could we be more specific in the message - Cannot activate the X extension because it depends on the Y extensions which is not supported in Restricted Mode. Could we also add an action called Manage Workspace Trust which would open the workspace trust editor?

[sandy081]

Done

[chrmarti]

Cloning a Repository Container now fails in a new empty window (and untrusted workspaces in general): microsoft/vscode-remote-release#5134. Is there a way to make the repository picker available when the workspace is not trusted yet?

[sandy081]

It seems @eamodio changed back to support git & GitHub extensions to be supported in untrusted workspaces. So @chrmarti your scenario shall work now.