Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto disable extensions if their dependencies are disabled #122448

Closed
rebornix opened this issue Apr 27, 2021 · 10 comments
Closed

Auto disable extensions if their dependencies are disabled #122448

rebornix opened this issue Apr 27, 2021 · 10 comments
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan workspace-trust Trusted workspaces
Milestone

Comments

@rebornix
Copy link
Member

rebornix commented Apr 27, 2021

Testing #122252

  • Trust a workspace
  • Remove it from the settings
  • An error notification showed up

image

@sbatten
Copy link
Member

sbatten commented Apr 28, 2021

@sandy081 @connor4312 is this some result of one being onboarded and the other not?

@sandy081
Copy link
Member

Yeah seems like so.

@connor4312
Copy link
Member

The old vscode-node-debug does not require trust since debugging goes to node-debug2 now. We can just require trust for both, the moment you do anything with node-debug you'll get a trust prompt.

@sbatten
Copy link
Member

sbatten commented Apr 28, 2021

I think the extension enablement service should check dependencies and use most restrictive option for enablement, this probably shouldn't be on the extensions to do themselves

@sandy081
Copy link
Member

Agreed, there is similar requirement for virtual workspaces.

@sandy081 sandy081 self-assigned this Apr 29, 2021
@lszomoru
Copy link
Member

@sandy081, is this something that you will address or you want me to look at?

@sandy081
Copy link
Member

I would look into this as it is also needed for virtual workspaces.

@sandy081 sandy081 added extensions Issues concerning extensions feature-request Request for new features or functionality labels Apr 29, 2021
@sandy081 sandy081 added this to the May 2021 milestone Apr 29, 2021
@sandy081 sandy081 changed the title Extension activation failure notification when switching workspace to restricted mode Auto disable extensions if their dependencies are disabled Apr 29, 2021
@sandy081 sandy081 added the workspace-trust Trusted workspaces label Jun 3, 2021
@sandy081 sandy081 modified the milestones: May 2021, June 2021 Jun 3, 2021
@lszomoru
Copy link
Member

@sandy081, have you had the chance to look into this issue? Thanks!

@sandy081
Copy link
Member

Not yet, scheduled it for next week.

@sandy081
Copy link
Member

Dependents are disabled when dependencies are disabled and following message is shown:

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan workspace-trust Trusted workspaces
Projects
None yet
Development

No branches or pull requests

6 participants
@rebornix @connor4312 @lszomoru @sbatten @sandy081 and others