Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node-pty in vscode and remove any case on ptyProcess #114215

Closed
Tyriar opened this issue Jan 12, 2021 · 1 comment
Closed

Update node-pty in vscode and remove any case on ptyProcess #114215

Tyriar opened this issue Jan 12, 2021 · 1 comment
Assignees
@meganrogge
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal General terminal issues that don't fall under another label
Milestone
January 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 12, 2021 •
edited
Loading

Part of #113827

After microsoft/node-pty#451 is done we need to update vscode's node-pty to the latest (let's do this part on master. As part of the same update we need to remove the bad casts here (in tyriar/flow_control):

vscode/src/vs/workbench/contrib/terminal/node/terminalProcess.ts

Lines 175 to 176 in c6c7ddd

// TODO: Expose as public API in node-pty
(ptyProcess as any).pause();

vscode/src/vs/workbench/contrib/terminal/node/terminalProcess.ts

Lines 342 to 343 in c6c7ddd

// TODO: Expose as public API in node-pty
(this._ptyProcess as any).resume();

@Tyriar Tyriar added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label labels Jan 12, 2021
@Tyriar Tyriar added this to the January 2021 milestone Jan 12, 2021
@Tyriar Tyriar mentioned this issue Jan 12, 2021
Merged
10 tasks
@Tyriar
Copy link
Member Author

Tyriar commented Jan 14, 2021

Included in test #114378

lszomoru pushed a commit that referenced this issue Jan 15, 2021
@meganrogge @lszomoru
fix #114215
6adade6
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2021
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@meganrogge
fix microsoft#114215
b883dfc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
January 2021
Development

No branches or pull requests
3 participants
@Tyriar @meganrogge and others