Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: terminal flow control #114378

Closed
3 tasks
meganrogge opened this issue Jan 14, 2021 · 1 comment
Closed
3 tasks

Test: terminal flow control #114378

meganrogge opened this issue Jan 14, 2021 · 1 comment
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@meganrogge
Copy link
Contributor

Refs #113827

  • wsl
  • ssh
  • web

Complexity: 4

Authors: @Tyriar, @meganrogge


Background
When the terminal produces a lot of data, the flow control mechanism is designed to prevent node-pty and its process from getting too far ahead of xterm.js.

Action:

  • Turn on the flow control setting, terminal.flowControl
  • Test with terminal.integrated.serverSpawn on and off
  • Run programs in the terminal that produce a lot of data, for example:
- yes
- while true; do echo test; done
- base64 /dev/urandom

Expectation::
The terminal doesn't disconnect and the UI doesn't slow down.

@meganrogge meganrogge added this to the January 2021 milestone Jan 14, 2021
@Tyriar
Copy link
Member

Tyriar commented Jan 14, 2021

/duplicate #114377

@Tyriar Tyriar closed this as completed Jan 14, 2021
@Tyriar Tyriar removed this from the January 2021 milestone Jan 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants
@Tyriar @meganrogge and others