Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If I drag up from the root of workspace and try to new terminal, vscode crashes. #111463

Closed
hJinRong opened this issue Nov 29, 2020 · 6 comments
Closed

If I drag up from the root of workspace and try to new terminal, vscode crashes. #111463

hJinRong opened this issue Nov 29, 2020 · 6 comments
Assignees
@sbatten @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
January 2021

Comments

@hJinRong
Copy link

hJinRong commented Nov 29, 2020 •
edited
Loading

  • VSCode Version: 1.51.1 (system setup)
  • OS Version: Windows_NT x64 10.0.19041

Steps to Reproduce:

  1. When I drag up from the root of workspace and try to new terminal, vscode crashes.

2020-11-29 214717

2020-11-29 221720

settings.json 

"terminal.integrated.shell.windows": "C:\\Program Files\\PowerShell\\7\\pwsh.exe",
Devtool warnings 

[688] potential listener LEAK detected, having 791 listeners already. MOST frequent listener (617):
    at new e (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6915:386)
    at d._createInstance (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1725:671)
    at d.createInstance (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1725:92)
    at e.getActions (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6930:345)
    at e.collectCompositeActions (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6311:692)
    at e.hideActiveComposite (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6312:269)
    at e.hideActivePanel (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6930:795)
    at L.setPanelHidden (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7015:61)
    at Object.hidePart (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6921:609)
    at _.resetActiveComposite (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6785:776)
    at _.hideComposite (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6784:682)
    at e.hideComposite (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6926:467)
    at e.onPanelOpen (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6927:142)
    at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6925:813
    at c.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:99:67)
    at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:94:636
    at c.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:99:67)
    at e.doOpenComposite (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6308:668)
    at e.openComposite (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6308:136)
    at e.doOpenPanel (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6929:599)
    at e.openPanel (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6929:688)
    at L.setPanelHidden (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7015:217)
    at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7010:47
    at c.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:99:67)
    at e.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3180:999)
    at v.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:640:108)
    at v.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:609:179)
    at S.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:613:741)
    at m.setChildVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:634:893)
    at f.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:646:359)
    at p.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:653:407)
    at L.setPanelHidden (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7015:294)
    at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7010:47
    at c.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:99:67)
    at e.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3180:999)
    at v.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:640:108)
    at v.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:609:179)
    at S.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:613:741)
    at m.setChildVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:634:893)
    at f.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:646:359)
    at p.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:653:407)
    at L.setPanelHidden (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7015:294)
    at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7010:47
    at c.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:99:67)
    at e.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3180:999)
    at v.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:640:108)
    at v.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:609:179)
    at S.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:613:741)
    at m.setChildVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:634:893)
    at f.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:646:359)
    at p.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:653:407)
    at L.setPanelHidden (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7015:294)
    at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7010:47
    at c.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:99:67)
    at e.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3180:999)
    at v.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:640:108)
    at v.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:609:179)
    at S.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:613:741)
    at m.setChildVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:634:893)
    at f.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:646:359)
    at p.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:653:407)
    at L.setPanelHidden (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7015:294)
    at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7010:47
    at c.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:99:67)
    at e.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3180:999)
    at v.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:640:108)
    at v.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:609:179)
    at S.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:613:741)
    at m.setChildVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:634:893)
    at f.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:646:359)
    at p.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:653:407)
    at L.setPanelHidden (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7015:294)
    at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7010:47
    at c.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:99:67)
    at e.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3180:999)
    at v.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:640:108)
    at v.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:609:179)
    at S.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:613:741)
    at m.setChildVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:634:893)
    at f.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:646:359)
    at p.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:653:407)
    at L.setPanelHidden (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7015:294)
    at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7010:47
    at c.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:99:67)
    at e.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3180:999)
    at v.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:640:108)
    at v.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:609:179)
    at S.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:613:741)
    at m.setChildVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:634:893)
    at f.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:646:359)
    at p.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:653:407)
    at L.setPanelHidden (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7015:294)
    at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:7010:47
    at c.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:99:67)
    at e.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3180:999)
    at v.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:640:108)
    at v.setVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:609:179)
    at S.setViewVisible (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:613:741)

I found out that every time VsCode added 88 listeners until it was a few hundred, and then VsCode crashed。

Does this issue occur when all extensions are disabled?: Yes
@vscodebot
Copy link

vscodebot bot commented Nov 29, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@meganrogge
Copy link
Contributor

meganrogge commented Nov 30, 2020 •
edited
Loading

does this happen if you click the menu item Terminal and select New Terminal?

I'm seeing this when I use Ctrl+J and when I drag up from the bottom, but not when I use the menu.

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label confirmed Issue has been confirmed by VS Code Team member labels Nov 30, 2020
@meganrogge meganrogge added this to the Backlog milestone Nov 30, 2020
@hJinRong
Copy link
Author

hJinRong commented Dec 1, 2020

does this happen if you click the menu item Terminal and select New Terminal?

I'm seeing this when I use Ctrl+J and when I drag up from the bottom, but not when I use the menu.

menu item Terminal >> select New Terminal: It is normal
Ctrl + J / drag up from the bottom: vscode crashed

I was in the same situation as you.

This was referenced Dec 1, 2020
Closed
Closed
@sguillia sguillia mentioned this issue Dec 8, 2020
Closed
@meganrogge
Copy link
Contributor

@sguillia @hJinRong @jaques-sam @cryonayes

The solution is to right click here and select Reset Location

term

sbatten added a commit that referenced this issue Dec 10, 2020
@sbatten
refs #111463
c503386
@sbatten sbatten self-assigned this Dec 10, 2020
@sbatten
Copy link
Member

sbatten commented Dec 10, 2020

I have pushed a fix that resolves the issue without the workaround for the future. To verify @meganrogge has a cache of their user data dir that reliably repros the issue.

@rzhao271 rzhao271 mentioned this issue Jan 19, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2021
@chrmarti
Copy link
Collaborator

@meganrogge Reading above that you can verify this issue. 👍

@meganrogge meganrogge added the verified Verification succeeded label Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
January 2021
Development

No branches or pull requests
4 participants
@sbatten @chrmarti @meganrogge @hJinRong