Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting to disable dragging to open terminal #112093

Closed
sguillia opened this issue Dec 8, 2020 · 12 comments
Closed

Setting to disable dragging to open terminal #112093

sguillia opened this issue Dec 8, 2020 · 12 comments
Assignees
Labels
feature-request Request for new features or functionality workbench-dnd Drag-and-drop issues

Comments

@sguillia
Copy link

sguillia commented Dec 8, 2020

TL;DR

Setting to opt-out of "drag to open terminal" because the right border of the window doesn't belong to the scrollbar anymore.

Description

This ticket is about a regression in the Insider build.

The regression was introduced by a feature called that I'll call "drag to open terminal".

On the Insider build, I can drag the utter right of the window to the left and it will open the workbench panel.

By workbench panel I mean the panel containing the terminal, debug console etc.

This feature is referred to in #111463

This feature seems to be introduced in Insider and seems to be absent in Code 1.51.1

Problem

When I want to scroll, I can just move my mouse completely to the right without caring.
At that point, my cursor has the default pointer.
When I click, the editor will scroll to the desired position.
This is great.

Now on the Insider build:
When I want to scroll, I move my mouse completely to the right without caring.
At that point, my cursor has the drag appearance.
When I click, nothing happens (because window expected me to drag)
This is not great.

I'd like a setting to opt-out of this feature, or any other experience where I do not have to precisely focus my mouse pointer on the scroll bar instead of the right border of the window that used to belong to the scroll bar.

It's like the "close" button on macOS windows, you have to precisely click on that ridiculously small button instead of just pushing your mouse top right.

Version

Version: 1.51.1
Commit: e5a624b788d92b8d34d1392e4c4d9789406efe8f
Date: 2020-11-10T23:31:29.624Z
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Linux x64 4.15.0-123-generic

Version: 1.52.0-insider
Commit: 92192baf760315ac47fb2caaf3ce6d0778962352
Date: 2020-12-03T05:44:34.000Z
Electron: 9.3.5
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Linux x64 4.15.0-123-generic
@meganrogge meganrogge added the terminal General terminal issues that don't fall under another label label Dec 8, 2020
@meganrogge meganrogge added this to the Backlog milestone Dec 8, 2020
@sguillia
Copy link
Author

Does not reproduce in 1.52.1
Does not reproduce in 1.53.0-insider

I guess the regression never made its way to the stable build

Thank you

@sguillia
Copy link
Author

This problem happens again, but only in full-screen mode.

Version: 1.53.0-insider
Commit: 861a88ebadb4335df92251faf6420b598440e082
Date: 2021-01-29T21:49:47.914Z
Electron: 11.2.1
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Linux x64 4.15.0-133-generic

@sguillia sguillia reopened this Feb 24, 2021
@meganrogge meganrogge added the bug Issue identified by VS Code Team member as probable bug label Feb 26, 2021
@isra-fel
Copy link

+1 for horizontal scroll bar as well in zen mode
Please make the "drag to open panel" feature configurable. Thanks

@Tyriar
Copy link
Member

Tyriar commented May 25, 2021

Am I understanding this right that it's about the red line (right most pixel) below not scrolling the terminal?

image

@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label May 25, 2021
@isra-fel
Copy link

Hey @Tyriar , I believe @sguillia 's probem was about the same red line not scrolling the editor in full-screen mode, but opens the panel (terminal) instead.
I also believe they set the default location of the panel to right.

@Tyriar
Copy link
Member

Tyriar commented May 26, 2021

Oh OK, thanks for the clarification

@Tyriar Tyriar assigned sbatten and unassigned Tyriar and meganrogge May 26, 2021
@Tyriar Tyriar removed bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal General terminal issues that don't fall under another label labels May 26, 2021
@Tyriar Tyriar removed this from the Backlog milestone May 26, 2021
@tanhakabir tanhakabir added workbench-dnd Drag-and-drop issues bug Issue identified by VS Code Team member as probable bug labels Oct 4, 2021
@sbatten sbatten added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Oct 21, 2021
@sbatten sbatten added this to the Backlog Candidates milestone Oct 21, 2021
@sguillia
Copy link
Author

Here is a screen recording of the bug

bug-2021-10-25_00.26.01.mp4

As you can see in the video, the right bar edge is not scrolling in full-screen mode.

@sbatten I consider this issue as a bug, because the behavior is different in full-screen mode

@sbatten
Copy link
Member

sbatten commented Oct 25, 2021

@sguillia it is different in full screen mode by design as this is when we differentiate resizing of the window

@sguillia
Copy link
Author

sguillia commented Jan 6, 2022

@sbatten This bug is fixed in 1.63.2

If it was as designed, then your design has changed and is now better. I hope it will stay

@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality workbench-dnd Drag-and-drop issues
Projects
None yet
Development

No branches or pull requests

7 participants
@Tyriar @sbatten @isra-fel @tanhakabir @sguillia @meganrogge and others