-
Notifications
You must be signed in to change notification settings - Fork 30
Conda hook search #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conda hook search #648
Conversation
76b5954 to
6085288
Compare
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
src/managers/conda/condaUtils.ts
Outdated
| throw new Error( | ||
| `Conda hook not found in expected locations. Tried: ${condaRootCandidates.join( | ||
| ', ', | ||
| )} based on conda executable at ${condaPath}.`, | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not block the discovery right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm good point- will fix
fixes microsoft#619 since environmentPath for an environment can be "Path to the python binary or environment folder." need to update code to support if the path is directly to a python binary. If so get the parent, parent of the binary to get the venv folder
fixes microsoft/vscode-python#25316 --------- Co-authored-by: Anthony Kim <[email protected]>
fixes microsoft/vscode-python#25316