Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated settings and mark more settings as deprecated #7455

Merged
merged 5 commits into from
Sep 8, 2021

Conversation

joyceerhl
Copy link
Contributor

@joyceerhl joyceerhl commented Sep 8, 2021

Fix #7094 (part of #7168)

@joyceerhl joyceerhl marked this pull request as ready for review September 8, 2021 16:18
@joyceerhl joyceerhl requested a review from a team as a code owner September 8, 2021 16:18
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #7455 (72c80e3) into main (2569945) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #7455    +/-   ##
======================================
  Coverage     63%     64%            
======================================
  Files        361     361            
  Lines      22563   22495    -68     
  Branches    3416    3418     +2     
======================================
+ Hits       14415   14558   +143     
+ Misses      6943    6726   -217     
- Partials    1205    1211     +6     
Impacted Files Coverage Δ
src/client/ioc/container.ts 80% <0%> (-14%) ⬇️
...ience/interactive-common/notebookServerProvider.ts 64% <0%> (-9%) ⬇️
...ient/datascience/kernel-launcher/kernelLauncher.ts 86% <0%> (-7%) ⬇️
...er/jupyterInterpreterSubCommandExecutionService.ts 91% <0%> (-6%) ⬇️
.../datascience/jupyter/kernels/cellExecutionQueue.ts 89% <0%> (-5%) ⬇️
...ce/raw-kernel/liveshare/hostRawNotebookProvider.ts 76% <0%> (-3%) ⬇️
...t/datascience/notebook/vscodeNotebookController.ts 76% <0%> (-3%) ⬇️
...nt/datascience/editor-integration/hoverProvider.ts 50% <0%> (-3%) ⬇️
.../datascience/notebook/notebookControllerManager.ts 85% <0%> (-3%) ⬇️
src/client/datascience/jupyter/jupyterExecution.ts 60% <0%> (-2%) ⬇️
... and 55 more

@@ -1622,12 +1610,14 @@
"jupyter.allowLiveShare": {
"type": "boolean",
"default": true,
"deprecationMessage": "This setting is deprecated as Live Share support for the interactive window no longer exists in the Jupyter extension.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably enter a task on us to reimplement this. The liveshare team has a bug where people are complaining about this being removed: microsoft/live-share#4032

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #7460

@joyceerhl joyceerhl merged commit 7a0c4ac into main Sep 8, 2021
@joyceerhl joyceerhl deleted the dev/joyceerhl/cleanup-settings branch September 8, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review all settings, commands, activation events in package.json
4 participants