-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated settings and mark more settings as deprecated #7455
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7455 +/- ##
======================================
Coverage 63% 64%
======================================
Files 361 361
Lines 22563 22495 -68
Branches 3416 3418 +2
======================================
+ Hits 14415 14558 +143
+ Misses 6943 6726 -217
- Partials 1205 1211 +6
|
@@ -1622,12 +1610,14 @@ | |||
"jupyter.allowLiveShare": { | |||
"type": "boolean", | |||
"default": true, | |||
"deprecationMessage": "This setting is deprecated as Live Share support for the interactive window no longer exists in the Jupyter extension.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably enter a task on us to reimplement this. The liveshare team has a bug where people are complaining about this being removed: microsoft/live-share#4032
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened #7460
Fix #7094 (part of #7168)