Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review all settings, commands, activation events in package.json #7094

Closed
joyceerhl opened this issue Aug 12, 2021 · 0 comments · Fixed by #7455
Closed

Review all settings, commands, activation events in package.json #7094

joyceerhl opened this issue Aug 12, 2021 · 0 comments · Fixed by #7455
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues notebook-workflow Issues that interrupt expected or desirable behavior papercut 🩸 Something affecting the productivity of the team verified Verification succeeded

Comments

@joyceerhl
Copy link
Contributor

joyceerhl commented Aug 12, 2021

Some of these look like they can be removed

Already marked deprecated for >1 year

  • jupyter.runMagicCommands
  • jupyter.autoPreviewNotebooksInInteractivePane

Should be deprecated

  • jupyter.liveShareConnectionTimeout -- we have removed all our code to support Live Share
  • jupyter.allowLiveShare -- we have removed all our code to support Live Share
  • jupyter.allowImportFromNotebook -- not used anywhere
  • jupyter.ignoreVscodeTheme -- can't support this
  • jupyter.textOutputLimit -- should be a core VS Code setting
  • jupyter.maxOutputSize -- should be a core VS Code setting
  • jupyter.colorizeInputBox -- we have discussed input box discoverability in Improve interactive window input editor styling vscode#128766 and Builtin interactive window support vscode#126415 (comment), and we found that using background colors to draw attention to an area visually poses potential accessibility problems and is inconsistent with other treatments in VS Code. We have opted to render the input box as a notebook cell instead, which should solve the visibility issues that prompted the original colorization treatment. Therefore this setting can be deprecated as it will not be an option moving forward
  • jupyter.showCellInputCode -- we cannot support this without significant changes in VS Code
  • jupyter.allowInput -- controls whether to show an input box in the interactive window. We cannot support this without changes in VS Code
  • jupyter.searchForJupyter -- controls whether to search for a Jupyter-capable interpreter if the user-selected one doesn't work. This has not been supported for ~1 year
@joyceerhl joyceerhl added the bug Issue identified by VS Code Team member as probable bug label Aug 12, 2021
@rchiodo rchiodo added debt Code quality issues and removed needs-triage labels Aug 12, 2021
@greazer greazer added engineering notebook-workflow Issues that interrupt expected or desirable behavior papercut 🩸 Something affecting the productivity of the team labels Aug 25, 2021
@greazer greazer changed the title Review all settings in package.json Review all settings, commands, activation events in package.json Sep 2, 2021
@joyceerhl joyceerhl added this to the September 2021 milestone Sep 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2021
@DonJayamanne DonJayamanne reopened this Sep 28, 2021
@DonJayamanne DonJayamanne added the verified Verification succeeded label Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues notebook-workflow Issues that interrupt expected or desirable behavior papercut 🩸 Something affecting the productivity of the team verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants