Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the setting jupyter.enableKeyboardShortcuts #7256

Closed
DonJayamanne opened this issue Aug 24, 2021 · 3 comments
Closed

Remove the setting jupyter.enableKeyboardShortcuts #7256

DonJayamanne opened this issue Aug 24, 2021 · 3 comments
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link
Contributor

As we have a keymap extension this is no longer relevant

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Aug 24, 2021
@DonJayamanne DonJayamanne added this to the August 2021 milestone Aug 24, 2021
@joyceerhl
Copy link
Contributor

I put in a deprecationMessage for this setting. I think a deprecation message is better than deleting the settings immediately because it is an opportunity to educate users on what to migrate to instead. I would suggest that we only delete the setting 1-2 releases from now.

@greazer greazer added debt Code quality issues webview-cleanup and removed needs-triage labels Aug 25, 2021
@greazer
Copy link
Member

greazer commented Aug 26, 2021

Perhaps we use the opportunity here to remove all other deprecated settings. Need to check telemetry to make sure we don't pull something that we shouldn't.

@greazer
Copy link
Member

greazer commented Aug 26, 2021

Dupe of #7094

@greazer greazer closed this as completed Aug 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2021
@connor4312 connor4312 added the verified Verification succeeded label Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants