Abstract the Postgres management client to allow both single and flexible server by tonybaloney · Pull Request #1872 · microsoft/vscode-cosmosdb

tonybaloney · 2021-06-18T00:13:25Z

Implement server listing
Implement connection string
Implement database list
Implement provisioning

tonybaloney · 2021-06-18T01:07:55Z

server listing (both single and flexible)

tonybaloney · 2021-06-18T05:38:40Z

The provisioning for flexible creates the server but then hits this issue--

3:34:09 PM: Creating PostgreSQL Server "ant-flexi-2"... It should be ready in several minutes.
3:34:44 PM: Error: The resource type 'locations/azureAsyncOperation' could not be found in the namespace 'Microsoft.DBforPostgreSQL' for api version '2021-04-10-privatepreview'. The supported api-versions are '2017-12-01-preview,2017-12-01,2018-03-29-privatepreview,2020-10-05-privatepreview,2020-02-14-privatepreview,2020-02-14-preview,2020-11-05-preview'.

tonybaloney · 2021-06-18T06:55:40Z

Again for deleting single servers

The resource type 'locations/azureAsyncOperation' could not be found in the namespace 'Microsoft.DBforPostgreSQL' for api version '2021-04-10-privatepreview'. The supported api-versions are '2017-12-01-preview,2017-12-01,2018-03-29-privatepreview,2020-10-05-privatepreview,2020-02-14-privatepreview,2020-02-14-preview,2020-11-05-preview'.

wwlorey

The provisioning for flexible creates the server but then hits this issue--

3:34:09 PM: Creating PostgreSQL Server "ant-flexi-2"... It should be ready in several minutes.
3:34:44 PM: Error: The resource type 'locations/azureAsyncOperation' could not be found in the namespace 'Microsoft.DBforPostgreSQL' for api version '2021-04-10-privatepreview'. The supported api-versions are '2017-12-01-preview,2017-12-01,2018-03-29-privatepreview,2020-10-05-privatepreview,2020-02-14-privatepreview,2020-02-14-preview,2020-11-05-preview'.

I'm running into this as well. Do you know if/when that api version will be supported?

src/AzureDBExperiences.ts

src/postgres/commands/createPostgresServer/steps/PostgresServerSkuStep.ts

src/postgres/abstract/AbstractPostgresClient.ts

src/tree/SubscriptionTreeItem.ts

src/postgres/abstract/AbstractPostgresClient.ts

src/postgres/commands/createPostgresServer/steps/PostgresServerNameStep.ts

src/postgres/commands/createPostgresServer/steps/PostgresServerSkuStep.ts

src/tree/CosmosDBAccountWizard/CosmosDBAccountCreateStep.ts

tonybaloney · 2021-06-23T00:10:10Z

@wwlorey updates completed from the review

wwlorey · 2021-06-28T20:45:00Z

This looks good 👍👍 I'll wait until we hear back about the API problem before testing again & getting this merged

tonybaloney · 2021-06-28T23:02:25Z

This looks good 👍👍 I'll wait until we hear back about the API problem before testing again & getting this merged

There is an issue with the SDK release. I'm waiting for a patch and will update packages.json once it's done

ejizba

Sorry for jumping in here a little late, but I think there's too much duplicated code inside AbstractPostgresClient and models.ts. We lose a bit of type safety and risk some silly copy/paste bugs. We should be able to leverage TypeScript features like union types more heavily to clean it up

src/postgres/abstract/AbstractPostgresClient.ts

src/postgres/abstract/maps.ts

src/postgres/abstract/models.ts

src/postgres/commands/createPostgresServer/steps/PostgresServerNameStep.ts

src/postgres/abstract/maps.ts

tonybaloney · 2021-06-30T00:24:13Z

Sorry for jumping in here a little late, but I think there's too much duplicated code inside AbstractPostgresClient and models.ts. We lose a bit of type safety and risk some silly copy/paste bugs. We should be able to leverage TypeScript features like union types more heavily to clean it up

@ejizba thanks for the feedback. My TS knowledge is still pretty basic. This PR is still blocked on an SDK patch so I'll work through your feedback and update this PR.

tonybaloney · 2021-06-30T04:15:11Z

@ejizba refactored as per your feedback in bb01e7a

src/postgres/abstract/models.ts

src/tree/SubscriptionTreeItem.ts

src/postgres/abstract/models.ts

src/postgres/commands/createPostgresServer/steps/PostgresServerNameStep.ts

src/postgres/commands/createPostgresServer/steps/PostgresServerSkuStep.ts

Co-authored-by: Eric Jizba <ejizba@gmail.com>

tonybaloney · 2021-06-30T23:34:42Z

Blocked by pending update to Azure/azure-sdk-for-js#15979

tonybaloney · 2021-07-01T23:39:21Z

Related Azure/azure-sdk-for-js#16136

tonybaloney · 2021-07-06T09:27:29Z

@wwlorey @ejizba this PR is now finished/ready for review. the backend dependency on the JS SDK has been fixed and I've updated package.json with the new version

src/postgres/commands/createPostgresServer/steps/PostgresServerCreateStep.ts

src/postgres/commands/createPostgresServer/steps/PostgresServerNameStep.ts

src/postgres/commands/createPostgresServer/steps/PostgresServerCreateStep.ts

src/AzureDBExperiences.ts

tonybaloney · 2021-07-08T21:31:20Z

@ejizba amendments made in cb353d4

ejizba

Looks good to me! @wwlorey were you still going to double check?

wwlorey

Looks good 👍

tonybaloney added 3 commits June 18, 2021 09:17

Add flexible server to the package deps

e59b5a5

reformat package json

dd449ba

package updates

a2a3c21

tonybaloney requested a review from a team as a code owner June 18, 2021 00:13

tonybaloney marked this pull request as draft June 18, 2021 00:13

Create an abstraction to list servers from both single and flexible

30cc07a

tonybaloney added 3 commits June 18, 2021 11:28

Implement database listing

b959bca

Implement the delete server method

0aee0c9

Adapt the create server workflow to work with both single and flex

6f45fa8

tonybaloney added 3 commits June 18, 2021 16:18

Implement the firewall rule and server name APIs

c82e084

Update package lock

c613c41

Fix the single server password error

e9ac3af

tonybaloney added 2 commits June 18, 2021 17:11

Extend the base types

9053fb3

Propagate client options to fix the API versioning errors

dbc4f71

tonybaloney marked this pull request as ready for review June 18, 2021 07:23

tonybaloney changed the title ~~[WIP] Abstract the Postgres management client to allow both single and flexible server~~ Abstract the Postgres management client to allow both single and flexible server Jun 18, 2021

wwlorey reviewed Jun 22, 2021

View reviewed changes

tonybaloney added 3 commits June 23, 2021 09:58

Remove the interface and update method names based on PR review

eaedf83

Document the storage sizes

27b5527

Add more skus

6c088fe

ejizba reviewed Jun 29, 2021

View reviewed changes

Refactor from PR review

bb01e7a

ejizba reviewed Jun 30, 2021

View reviewed changes

tonybaloney and others added 3 commits July 1, 2021 08:44

Update src/postgres/abstract/models.ts

a653cb5

Co-authored-by: Eric Jizba <ejizba@gmail.com>

Another round of PR revisions

2e52481

Fix the abstract client listing

c6244c5

Update @azure/arm-postgresql-flexible to the patched version

e3e9197

ejizba reviewed Jul 8, 2021

View reviewed changes

tonybaloney added 3 commits July 8, 2021 12:29

Merge branch 'main' into postgres_patch_update

05f8b4a

Cleanup merge commit

4eaf7f1

Switch server resoure on name lookup for resource type

9626855

ejizba reviewed Jul 8, 2021

View reviewed changes

src/postgres/commands/createPostgresServer/steps/PostgresServerCreateStep.ts Outdated Show resolved Hide resolved

src/AzureDBExperiences.ts Outdated Show resolved Hide resolved

Set default versions and mention preview to flexible

cb353d4

ejizba approved these changes Jul 8, 2021

View reviewed changes

wwlorey approved these changes Jul 8, 2021

View reviewed changes

wwlorey merged commit ffd7f44 into microsoft:main Jul 8, 2021

tonybaloney deleted the postgres_patch_update branch July 8, 2021 23:26

neelip added this to the 0.18.0 milestone Jul 16, 2021

wwlorey mentioned this pull request Jul 29, 2021

Add eslint-config-azuretools package microsoft/vscode-azuretools#972

Merged

github-actions bot locked and limited conversation to collaborators Aug 23, 2021

Conversation

tonybaloney commented Jun 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tonybaloney commented Jun 18, 2021

Uh oh!

tonybaloney commented Jun 18, 2021

Uh oh!

tonybaloney commented Jun 18, 2021

Uh oh!

wwlorey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tonybaloney commented Jun 23, 2021

Uh oh!

wwlorey commented Jun 28, 2021

Uh oh!

tonybaloney commented Jun 28, 2021

Uh oh!

ejizba left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tonybaloney commented Jun 30, 2021

Uh oh!

tonybaloney commented Jun 30, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tonybaloney commented Jun 30, 2021

Uh oh!

tonybaloney commented Jul 1, 2021

Uh oh!

tonybaloney commented Jul 6, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tonybaloney commented Jul 8, 2021

Uh oh!

ejizba left a comment

Choose a reason for hiding this comment

Uh oh!

wwlorey left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tonybaloney commented Jun 18, 2021 •

edited

Loading