Pass args #1603
Merged
Pass args #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for addressing the launch args problem in this PR. This was previously attempted with #1201 and we still need to figure out how this would work in more complicated terminal and quoting scenarios. We will revisit this after the holidays to make a decision. |
|
#1598 are also ralted, launch program also need specify proper environment variables. |
andreeis
approved these changes
Feb 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this change
When we launch the executable in the debuger, it uses the args parameter. But when we launch it without the debuger
it doesn't.
This change provides the same behaviour and allow to pass args when we launch without debug the executable/