Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional launch args #1201

Closed
wants to merge 3 commits into from
Closed

Conversation

cogilvie
Copy link

This change addresses item [[#924]]

This changes [[visible behavior]]

The following changes are proposed:

  • This allows specifying arguments to be used with Launch without Debug

This allows specifying arguments to be used with Launch without Debug
@msftclas
Copy link

msftclas commented Apr 24, 2020

CLA assistant check
All CLA requirements met.

@andreeis
Copy link
Contributor

Thank you for looking into fixing this.

  1. We recommend is to not add a new array setting and use instead the args array in "cmake.debugConfig".

  2. There might be various problems with quotes and argument passing in different terminals, which this PR does not cover and which would be better addressed centrally in VSCode by some API that would benefit all extensions.

  3. We will not be ready to take this PR for the upcoming release but we want to investigate what options are there about passing an arguments array to a terminal in VSCode.

I opened an issue in the VSCode repo. microsoft/vscode#96091. Let's see what this team will suggest.

@bobbrow bobbrow added this to the Tracking milestone May 7, 2020
@Tudyx
Copy link

Tudyx commented Dec 25, 2020

Any news on this PR?

@andreeis andreeis modified the milestones: Tracking, 1.7.0 Feb 11, 2021
@andreeis
Copy link
Contributor

We merged PR #1603 which overlapped with yours. That had simpler code and being more recent didn't have conflicts. It was easier to merge.
I actually merged some conflicts first, without realizing it's into your branch (I apologize) and that caused the typescript to fail (not where I merged, somewhere else, I wonder how it compiled before). Now there's one more conflict which you can solve if you want to continue with what this PR had extra than the other one, which is some nice refactoring around getDebugConfig. Not critical though (or let me know if I'm missing anything).

@andreeis
Copy link
Contributor

andreeis commented Mar 1, 2021

Closing this PR for now.

@andreeis andreeis closed this Mar 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants