Skip to content

[angle] Improve port#9965

Merged
dan-shaw merged 14 commits intomicrosoft:masterfrom
Neumann-A:improve_angle
Apr 6, 2020
Merged

[angle] Improve port#9965
dan-shaw merged 14 commits intomicrosoft:masterfrom
Neumann-A:improve_angle

Conversation

@Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Feb 7, 2020

  • update opengl-registry
  • give opengl-registry headers priority
  • allow static builds
  • make cmake build more equivalent to native builds.

@PhoebeHui
Copy link
Contributor

PhoebeHui commented Feb 20, 2020

@Neumann-A, glad failed on windows all triplets on CI testing, does this expect?

@Neumann-A
Copy link
Contributor Author

Neumann-A commented Feb 20, 2020

@PhoebeHui It seems to be a file encoding problem. After changing the encoding of the *.xml files from UTF-8 with BOM to only UTF-8 glad compiled fine. The problem is I don't know the best way to remove the BOM with CMake.

JackBoosY
JackBoosY suggested changes Feb 21, 2020
View reviewed changes
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 22, 2020
@dan-shaw
Copy link
Contributor

dan-shaw commented Mar 28, 2020

@Neumann-A Sorry for the delay. During the weekend, I will review your PRs: #9965, #9864, #9861, #9705 and more.

@Vincent-P Vincent-P mentioned this pull request Apr 3, 2020
Merged
@dan-shaw dan-shaw merged commit 6028fd5 into microsoft:master Apr 6, 2020
@Neumann-A Neumann-A deleted the improve_angle branch April 6, 2020 22:09
vserdyuk
vserdyuk reviewed Nov 1, 2020
View reviewed changes
ports/angle/CMakeLists.txt Outdated
SET_TARGET_PROPERTIES(libEGL PROPERTIES PREFIX "")

install(TARGETS libEGL libGLESv2 EXPORT ANGLEExport
install(TARGETS libEGL libGLESv2 libANGLE angle_common angle_image_util angle_gpu_info_util angle_translator angle_preprocessor angle_renderer_opengl EXPORT ANGLEExport
Copy link
Contributor

@vserdyuk vserdyuk Nov 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even when using x64-windows triplet which uses dynamic linkage, libANGLE.lib is put into installed\x64-windows\lib
and it's about 830 MiB in size. Together with installed\x64-windows\debug\lib\libANGLE.lib (880 MiB) this single line adds 1.67 GiB of unnecessary bloat. Please, install static libraries only when x64-windows-static is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@vserdyuk vserdyuk vserdyuk left review comments

@JackBoosY JackBoosY JackBoosY approved these changes

@dan-shaw dan-shaw dan-shaw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PhoebeHui PhoebeHui

@JackBoosY JackBoosY

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Neumann-A @PhoebeHui @dan-shaw @vserdyuk @JackBoosY @strega-nil