Skip to content

[hdf5] add tools and fortran feature#9864

Merged
dan-shaw merged 3 commits intomicrosoft:masterfrom
Neumann-A:add_hdf5_tools
Mar 29, 2020
Merged

[hdf5] add tools and fortran feature#9864
dan-shaw merged 3 commits intomicrosoft:masterfrom
Neumann-A:add_hdf5_tools

Conversation

@Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Jan 31, 2020

No description provided.

@Neumann-A Neumann-A mentioned this pull request Jan 31, 2020
Closed
@JackBoosY JackBoosY assigned JackBoosY and NancyLi1013 and unassigned JackBoosY Feb 1, 2020
JackBoosY
JackBoosY suggested changes Feb 20, 2020
View reviewed changes
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 20, 2020
@strega-nil
Copy link
Contributor

strega-nil commented Mar 10, 2020

Is this a WIP PR? Or are we going to merge it with the feature unsupported?

@JackBoosY JackBoosY added waiting for response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Mar 11, 2020
@Neumann-A
Copy link
Contributor Author

Neumann-A commented Mar 18, 2020

Is this a WIP PR? Or are we going to merge it with the feature unsupported?

I consider this PR finished.
The feature is only unsupported since a newer ninja is required and due to the fact that on windows vcpkg does not have an automatic fortran compiler download. If you manually setup everything it should work.

@strega-nil
Copy link
Contributor

strega-nil commented Mar 18, 2020

Cool! We'll discuss this at our next PR meeting :)

@JackBoosY JackBoosY added needs-feature-review info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed waiting for response labels Mar 19, 2020
BillyONeal
BillyONeal reviewed Mar 19, 2020
View reviewed changes
@JackBoosY JackBoosY added waiting for response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Mar 20, 2020
@JackBoosY
Copy link
Contributor

JackBoosY commented Mar 22, 2020

/azp run

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Mar 27, 2020

/azp run

@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed waiting for response labels Mar 27, 2020
@dan-shaw dan-shaw mentioned this pull request Mar 28, 2020
Merged
@dan-shaw dan-shaw merged commit b79f767 into microsoft:master Mar 29, 2020
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Mar 29, 2020
@Jimmy-Hu
Merge pull request #173 from microsoft/master
ba1c7fb 
[hdf5] add tools and fortran feature (microsoft#9864)
@Neumann-A Neumann-A deleted the add_hdf5_tools branch March 29, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

+3 more reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

@dan-shaw dan-shaw dan-shaw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Neumann-A @strega-nil @JackBoosY @NancyLi1013 @BillyONeal @dan-shaw