[xerces-c] Change url for xerces-c and the signature#9655
[xerces-c] Change url for xerces-c and the signature#9655hailIulius wants to merge 1 commit intomicrosoft:masterfrom
Conversation
| @@ -3,8 +3,8 @@ include(vcpkg_common_functions) | |||
| vcpkg_from_github( | |||
There was a problem hiding this comment.
include(vcpkg_common_functions) is no longer needed.
Could you please remove this line?
| REPO apache/xerces-c | ||
| REF Xerces-C_3_2_2 | ||
| SHA512 66f60fe9194376ac0ca99d13ea5bce23ada86e0261dde30686c21ceb5499e754dab8eb0a98adadd83522bda62709377715501f6dac49763e3a686f9171cc63ea | ||
| REF v3.2.2 |
There was a problem hiding this comment.
Could you please use commit id 71cc0e831b522933ae58253fcaf4423a166e6bec instead of tag name in REF place?
| SHA512 e4b2d3499fb4d1d1bcaf991ee858f352112683084b9cc7855c0e52e7fc8cc982a8e3cd548fa30718af6a6dee40e460d82ffcd3480a50f7e7516b462b2c2080c6 | ||
| HEAD_REF trunk | ||
| PATCHES | ||
| disable-tests.patch |
There was a problem hiding this comment.
Could you update
configure_file(
${CMAKE_CURRENT_LIST_DIR}/vcpkg-cmake-wrapper.cmake
${CURRENT_PACKAGES_DIR}/share/xercesc
@ONLY
)
as
file(INSTALL ${CMAKE_CURRENT_LIST_DIR}/vcpkg-cmake-wrapper.cmake DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT})?
There was a problem hiding this comment.
Could you update
file(COPY ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/xerces-c)
file(RENAME ${CURRENT_PACKAGES_DIR}/share/xerces-c/LICENSE ${CURRENT_PACKAGES_DIR}/share/xerces-c/copyright)
as
file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright) ?
|
Hi @hailIulius thanks for this PR. Since Could you please open an issue for this problem? |
|
/azp run |
|
Related #9726. |
|
The PR #9702 has been merged. |
|
Closing this PR since it seems that no progress is being made and also the changes has been merged by #9702. |
Describe the pull request
What does your PR fix? Fixes issue #
Which triplets are supported/not supported? Have you updated the CI baseline?
No impact on the triplet only the git download is fixed
Does your PR follow the maintainer guide?
Yes, the change is small enough to have any impact than the download url and the sha hash