Skip to content

[xerces-c] Change url for xerces-c and the signature#9655

Closed
hailIulius wants to merge 1 commit intomicrosoft:masterfrom
hailIulius:master
Closed

[xerces-c] Change url for xerces-c and the signature#9655
hailIulius wants to merge 1 commit intomicrosoft:masterfrom
hailIulius:master

Conversation

@hailIulius
Copy link

Describe the pull request

  • What does your PR fix? Fixes issue #

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    No impact on the triplet only the git download is fixed

  • Does your PR follow the maintainer guide?
    Yes, the change is small enough to have any impact than the download url and the sha hash

@@ -3,8 +3,8 @@ include(vcpkg_common_functions)
vcpkg_from_github(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include(vcpkg_common_functions) is no longer needed.
Could you please remove this line?

REPO apache/xerces-c
REF Xerces-C_3_2_2
SHA512 66f60fe9194376ac0ca99d13ea5bce23ada86e0261dde30686c21ceb5499e754dab8eb0a98adadd83522bda62709377715501f6dac49763e3a686f9171cc63ea
REF v3.2.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please use commit id 71cc0e831b522933ae58253fcaf4423a166e6bec instead of tag name in REF place?

SHA512 e4b2d3499fb4d1d1bcaf991ee858f352112683084b9cc7855c0e52e7fc8cc982a8e3cd548fa30718af6a6dee40e460d82ffcd3480a50f7e7516b462b2c2080c6
HEAD_REF trunk
PATCHES
disable-tests.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update

configure_file(
    ${CMAKE_CURRENT_LIST_DIR}/vcpkg-cmake-wrapper.cmake
    ${CURRENT_PACKAGES_DIR}/share/xercesc
    @ONLY
)

as
file(INSTALL ${CMAKE_CURRENT_LIST_DIR}/vcpkg-cmake-wrapper.cmake DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT})?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update

file(COPY ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/xerces-c)
file(RENAME ${CURRENT_PACKAGES_DIR}/share/xerces-c/LICENSE ${CURRENT_PACKAGES_DIR}/share/xerces-c/copyright)

as
file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright) ?

@NancyLi1013 NancyLi1013 changed the title Change url for xerces-c and the signature [xerces-c] Change url for xerces-c and the signature Jan 14, 2020
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Jan 14, 2020

Hi @hailIulius thanks for this PR.
Could you also bump the version as 3.2.2-12 in CONTROL file?
I noticed msix failed on x86-windows triplets:

optimized;C:/vsts/_work/3/s/installed/x86-windows/lib/zlib.lib;debug;C:/vsts/_work/3/s/installed/x86-windows/debug/lib/zlibd.lib (found version "1.2.11") 
-- libs processed
-- Resource files:
CMake Error at cmake/msix_resources.cmake:343 (configure_file):
  configure_file Problem configuring file
Call Stack (most recent call first):
  src/msix/CMakeLists.txt:87 (include)

Since msix depends on xerces-c. Could you try to fix it?

Could you please open an issue for this problem?

@NancyLi1013
Copy link
Contributor

/azp run

@NancyLi1013
Copy link
Contributor

Related #9726.

@NancyLi1013
Copy link
Contributor

The PR #9702 has been merged.
Is this PR active?

@NancyLi1013
Copy link
Contributor

Closing this PR since it seems that no progress is being made and also the changes has been merged by #9702.

@NancyLi1013 NancyLi1013 closed this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants