[ace] Let ssl feature able to work on Linux when selected#9016
[ace] Let ssl feature able to work on Linux when selected#9016vicroms merged 10 commits intomicrosoft:masterfrom gnaggnoyil:master
ssl feature able to work on Linux when selected#9016Conversation
|
Also, there seems to be other issues on current portfile too:
I'm not sure whether these should be considered as issue or not, therefore this PR isn't going to touch them too much. |
|
/azp run |
|
OK I just found a more serious problem: those libraries generated under Therefore that the original |
|
/azp run |
|
See #9074 for the upgrade to the latest ACE release |
|
@jwillemsen Sure, I'll update my PR once upstream's ACE version in port is updated. |
|
/azp run |
|
#9074 has been merged. |
|
PR updated. What's the meaning of the error messgae in the azure pipeline? Does it indicates a test failure? |
|
Hmm... so indeed it indicates a test failure but That's stange... I've checked the command |
|
I can repro it on my machine now. And I found this file exists in SOURCE_PATH/bin/MakeProjectCreator/templates/gnu.mpd SOURCE_PATH/MPC/modules/Options.pm Do they have a relationship? |
JackBoosY
left a comment
JackBoosY
left a comment
There was a problem hiding this comment.
I prefer to use the following structure:
if (VCPKG_TARGET_IS_WINDOWS)
... //Windows
else()
... //UNIX
endif()
|
@JackBoosY No, I think those are probably unrelated with CI's test failure. |
|
Ahh... test under linux failed again.. This time, So |
|
install-x64-linux-dbg-out.log: install-x64-linux-dbg-err.log: make-x64-linux-dbg-err.log: make-x64-linux-dbg-out.log: |
|
Does it work locally with the updated portfile? Did test my changes in the past for Windows locally, that helped a lot to find issues |
|
@jwillemsen Yes tested with Archlinux latest and Ubuntu 18.04, both of which work. That's why I'm having no idea about this CI test failure. |
|
No idea why this fails on CI when it works locally. |
This file should exist in source path, can you check this? Thanks. |
|
@gnaggnoyil , thanks for the PR! |
|
@PhoebeHui Sorry I forgot to bump tweak version before. I've bumped it now. @JackBoosY Is path |
|
@gnaggnoyil File |
|
Just have this CI failure reproduceable in a fresh Ubuntu 18.04 docker container, where the failure seems to be the issue described in https://www.perlmonks.org/?node_id=322531 . It seems solutions provided by the link above can solve this failure, yet I still have no idea why such failure doesn't happen on my WSL distributions. Perhaps I should run tests on a real Linux machine but now I'm going to fix this failure first. |
|
The port file always downloads the zip file which has windows line endings, for non-windows systems we ship .tar.gz/.tar.bz2 files, maybe you can select a different file to download? |
|
Any updates on this one? |
|
/azp run |
1 similar comment
|
/azp run |
|
So many package installation failed on osx that seems to be unreleated with this PR. What was happening there? |
|
@gnaggnoyil These failure have no relationship with this PR, and we are fixing that. |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9016 in repo microsoft/vcpkg |
| vcpkg_copy_pdbs() | ||
|
|
||
| # Handle copyright | ||
| file(COPY ${ACE_ROOT}/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/ace) |
There was a problem hiding this comment.
Looks this can be done in one step, see #9655 (comment)
There was a problem hiding this comment.
It seems to be. I'll have a look at it.
|
/azp run |
|
OSX fixes in #9726 |
|
Looks the xercesc issue got fixed, can someone rerun this PR on CI? |
8 participants
According to documentation(https://htmlpreview.github.io/?https://github.com/DOCGroup/ACE_TAO/blob/master/ACE/ACE-INSTALL.html#sslinstall), to build
ACE_SSLlibrary under Linux,ssl=1make option andSSL_ROOTenvironment variable need to be set when invokingmakecommand. The current portfile does not handle this thus lead to a install error:This PR is intended to fix such issue.