Merged
Conversation
strega-nil
force-pushed
the
sfgui-macos
branch
from
25e355f to
e942c15
Compare
15 tasks
dan-shaw
approved these changes
Jan 11, 2020
JackBoosY
approved these changes
Jan 11, 2020
JackBoosY
added
the
info:needs-maintainer-attention
Contributor
|
/azp run |
1 similar comment
Contributor
|
/azp run |
Contributor
Author
|
It seems that sfgui passed, does anyone have a problem with me merging? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a minor issue in the original CMakeLists.txt, which breaks SFGUI on macOS 10.15. The framework CoreFoundation is not linked correctly. It's a very simple fix, and just requires a small patch.
PR has been opened on upstream as well, at TankOs/SFGUI#82