Fix the macOS build for 10.15#82
Merged
eXpl0it3r merged 1 commit intoTankOs:masterfrom Sep 22, 2020
strega-nil:master
Merged
Conversation
The explicit way of linking CoreFoundation used in the existing CMakeLists.txt does not work on 10.15, and we can simplify it. The code I used is based on a StackOverflow comment, and does work on my machine; It builds, and HelloWorld runs perfectly well.
Contributor
Author
|
@jayr713 ? |
|
I ran into this this morning and had to manually apply this patch. Is there a reason it hasn't been merged to master? |
eXpl0it3r
approved these changes
Sep 21, 2020
Collaborator
|
@TankOs do you want to give this a look or can I merge it? 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The explicit way of linking CoreFoundation used in the existing
CMakeLists.txt does not work on 10.15, and we can simplify it. The code
I used is based on a StackOverflow comment, and does work on my machine;
It builds, and HelloWorld runs perfectly well.
fixes #81