[vcpkg] Add MAKE_OPTIONS and MAKE_INSTALL_OPTIONS#9569
[vcpkg] Add MAKE_OPTIONS and MAKE_INSTALL_OPTIONS#9569SeekingMeaning wants to merge 11 commits intomicrosoft:masterfrom SeekingMeaning:make-opts
Conversation
|
When I developed this set of functions, I didn't consider the scenario where I need to pass parameters when executing make. [1]. |
|
Hm... This would still require |
|
@SeekingMeaning I know what you mean. And my suggestion is to rename |
|
Could you please add some example to check it? |
|
Like a port? I have a local version of #9558 that uses this, is that okay? |
|
Yes please. |
|
Oh whoops, I forgot to update for the |
|
/azp run |
|
Quick question: should the port be removed before merge? |
|
@SeekingMeaning Hmm... I think you can combine two PRs into one and close #9558. |
|
Another question: I have this working with LuaJIT (which already exists as a port); should I wait to open a new pull request or add the changes to this one? |
|
If your changes are related to this PR, please submit to this PR. Thanks. |
|
Anything else? |
|
@SeekingMeaning No, we are waiting for fix osx PR test. See #9600. |
ras0219-msft
left a comment
There was a problem hiding this comment.
Unfortunately, CMake is much more performant when using a mutating style (via list(APPEND)) instead of a "constant single assigment" style like you're using here (XYZ_BASE, then set(XYZ ${XYZ_BASE} wqv)).
Please prefer the agglutinating, additive style using list(APPEND) instead.
|
Somehow we lost track of this PR. @SeekingMeaning can you fix the conflict? |
|
Sure, I'll have to open a new pull request though since the original fork was deleted |
This pull request allows for adding options for
makeandmake install. This is especially useful for projects that don't have aconfigurefile and only have aMakefile. Example usage:vcpkg_configure_make( SOURCE_PATH ${SOURCE_PATH} SKIP_CONFIGURE ) vcpkg_install_make( MAKE_INSTALL_OPTIONS_DEBUG "PREFIX=${CURRENT_PACKAGES_DIR}/debug" "BINDIR=${CURRENT_PACKAGES_DIR}/debug/tools/${PORT}" MAKE_INSTALL_OPTIONS_RELEASE "PREFIX=${CURRENT_PACKAGES_DIR}" "BINDIR=${CURRENT_PACKAGES_DIR}/tools/${PORT}" )