Skip to content

[luajit] Support UNIX#9060

Closed
JackBoosY wants to merge 5 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/5782
Closed

[luajit] Support UNIX#9060
JackBoosY wants to merge 5 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/5782

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Nov 21, 2019

Needs to install autoconfig and autobuild in UNIX.

Related: #5782.

Note: this port does not contain any features.

@JackBoosY JackBoosY requested a review from PhoebeHui November 21, 2019 08:30
@grdowns grdowns changed the title [luajit]Support UNIX. [luajit] Support UNIX Nov 21, 2019
@grdowns grdowns self-assigned this Nov 21, 2019
@JackBoosY JackBoosY marked this pull request as ready for review November 22, 2019 05:31
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Nov 22, 2019

I found that Linux / OSX was not tested. What's going wrong?

@ras0219-msft
Copy link
Contributor

ras0219-msft commented Nov 22, 2019

/azp run

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Nov 25, 2019

@ras0219-msft Still not tested.

PhoebeHui
PhoebeHui reviewed Nov 25, 2019
View reviewed changes
@vicroms
Copy link
Member

vicroms commented Dec 2, 2019

I've removed luajit from the CI exclusion list, as there are no documented conflicts.

@vicroms
Copy link
Member

vicroms commented Dec 2, 2019

/azp run

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 3, 2019
@dan-shaw dan-shaw assigned dan-shaw and unassigned grdowns Dec 11, 2019
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Jan 7, 2020

/azp run

1 similar comment
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Jan 14, 2020

/azp run

@PhoebeHui PhoebeHui self-assigned this Jan 14, 2020
@JackBoosY JackBoosY removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 24, 2020
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Feb 24, 2020

OSX build failure:

Undefined symbols for architecture x86_64:
  "__Unwind_DeleteException", referenced from:
      _lj_err_unwind_dwarf in libluajit.a(lj_err.o)
  "__Unwind_GetCFA", referenced from:
      _lj_err_unwind_dwarf in libluajit.a(lj_err.o)
  "__Unwind_RaiseException", referenced from:
      _lj_err_throw in libluajit.a(lj_err.o)
  "__Unwind_SetGR", referenced from:
      _lj_err_unwind_dwarf in libluajit.a(lj_err.o)
  "__Unwind_SetIP", referenced from:
      _lj_err_unwind_dwarf in libluajit.a(lj_err.o)
ld: symbol(s) not found for architecture x86_64

From official workaround, I think the PR should wait for #9569 to merge.

@JackBoosY
Copy link
Contributor Author

JackBoosY commented May 6, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented May 6, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Jun 11, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 11, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui PhoebeHui marked this pull request as draft July 14, 2020 02:51
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Oct 27, 2020

Temporary close this PR, will continue this work in the future.

@JackBoosY JackBoosY closed this Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

@dan-shaw dan-shaw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@JackBoosY @ras0219-msft @vicroms @PhoebeHui @BillyONeal @strega-nil @grdowns @dan-shaw