Skip to content

[bgfx] Add new port#9369

Closed
Outurnate wants to merge 7 commits intomicrosoft:masterfrom
Outurnate:bgfx
Closed

[bgfx] Add new port#9369
Outurnate wants to merge 7 commits intomicrosoft:masterfrom
Outurnate:bgfx

Conversation

@Outurnate
Copy link
Copy Markdown
Contributor

Rewrite of #9163

I've only written a port for bgfx. There's no way to get GENie to use the artifacts from another port (i.e. bx or bimg), so I saw little point in exposing them

There was a bug in vcpkg_build_make as well - the docs specified that there was a TARGET parameter where no such parameter existed. I added this parameter, as well as two others to override the target for debug/release builds

@JackBoosY
Copy link
Copy Markdown
Contributor

Seems have problem:

make: *** No rule to make target 'vs2017-debug32'.  Stop.

@Outurnate
Copy link
Copy Markdown
Contributor Author

A couple more changes in vcpkg_build_make. I added a new WORKING_DIRECTORY option. I removed the section that closes gpg-agent.exe on Windows since it doesn't work (the code was copy/pasted from the icu port - it still had a ref to a variable that was only in the original port). It seemed unnecessary since the process is a part of Msys2 and in no way prevents the build from completing

As it turns out, the windows make target for the project is sort of broken. The makefile just calls devenv PATH_TO_SLN /Build which ends up just launching Visual Studio. I used the makefile to generate the SLN file, then ran msbuild over that

@JackBoosY
Copy link
Copy Markdown
Contributor

/azp run

@JackBoosY
Copy link
Copy Markdown
Contributor

Only have windows build failure, please download failure log here and resolve them.

Thanks.

@Outurnate
Copy link
Copy Markdown
Contributor Author

There's nothing in any of those log bundles. I tested this port on the Windows 10 dev VM provided by Microsoft

@JackBoosY
Copy link
Copy Markdown
Contributor

@Outurnate I will provide your failure logs tomorrow.

@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Jan 17, 2020

@Outurnate I think you catch a vcpkg bug: #9729.


if(VCPKG_TARGET_IS_WINDOWS)
set(MAKE_TARGET_PLATFORM vs2017)
set(EXECUTABLE_SUFFIX ".exe")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove it and replace it to VCPKG_TARGET_EXECUTABLE_SUFFIX?

@LilyWangL
Copy link
Copy Markdown
Contributor

@Outurnate Can you address the review suggestions? Thanks!

@nyalloc
Copy link
Copy Markdown

nyalloc commented Apr 20, 2020

Would be really eager to see this library added to vcpkg.

@JackBoosY
Copy link
Copy Markdown
Contributor

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.

@JackBoosY JackBoosY closed this May 14, 2020
@Outurnate Outurnate deleted the bgfx branch August 3, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants