[bgfx] Add new port#9369
Conversation
|
Seems have problem: |
|
A couple more changes in As it turns out, the windows make target for the project is sort of broken. The makefile just calls |
|
/azp run |
|
Only have windows build failure, please download failure log here and resolve them. Thanks. |
|
There's nothing in any of those log bundles. I tested this port on the Windows 10 dev VM provided by Microsoft |
|
@Outurnate I will provide your failure logs tomorrow. |
|
@Outurnate I think you catch a vcpkg bug: #9729. |
|
|
||
| if(VCPKG_TARGET_IS_WINDOWS) | ||
| set(MAKE_TARGET_PLATFORM vs2017) | ||
| set(EXECUTABLE_SUFFIX ".exe") |
There was a problem hiding this comment.
Could you remove it and replace it to VCPKG_TARGET_EXECUTABLE_SUFFIX?
|
@Outurnate Can you address the review suggestions? Thanks! |
|
Would be really eager to see this library added to vcpkg. |
|
Closing this PR since it seems that no progress is being made. Please reopen if work is still being done. |
Rewrite of #9163
I've only written a port for bgfx. There's no way to get GENie to use the artifacts from another port (i.e. bx or bimg), so I saw little point in exposing them
There was a bug in vcpkg_build_make as well - the docs specified that there was a
TARGETparameter where no such parameter existed. I added this parameter, as well as two others to override the target for debug/release builds