[bgfx, bx, bimg] Add new ports#9163
[bgfx, bx, bimg] Add new ports#9163Outurnate wants to merge 5 commits intomicrosoft:masterfrom Outurnate:master
Conversation
|
All the necessary changes were made. I took the time to update the commit refs from the upstream. I've also added a step to include the shader compiler tool which is necessary for projects using bgfx There is a patch file included - I've submitted bkaradzic/bgfx#1958 to upstream this |
|
Can anyone provide some guidance on retrieving logs from Azure DevOps? One of the steps seems to reference storing the results in a container, but I can't figure out where that is |
| endif() | ||
|
|
||
| # Post-build test for cmake libraries | ||
| vcpkg_test_cmake(PACKAGE_NAME ${PORT}) |
There was a problem hiding this comment.
vcpkg_test_cmake is now disabled in vcpkg, please remove this line.
| vcpkg_install_cmake(TARGET bimg_encode/all) | ||
| vcpkg_install_cmake(TARGET bimg_decode/all) | ||
| # GENie does not generate an install target, so we install explicitly | ||
| file(INSTALL "${SOURCE_DIR}/include/bimg" DESTINATION "${CURRENT_PACKAGES_DIR}/include") |
There was a problem hiding this comment.
We prefer to add a patch to fix these installation issues instead of adding the installation code directly in portfile.cmake.
| ) | ||
| vcpkg_install_cmake(TARGET bx/all) | ||
| # GENie does not generate an install target, so we install explicitly | ||
| file(INSTALL |
There was a problem hiding this comment.
We prefer to add a patch to fix these installation issues instead of adding the installation code directly in portfile.cmake.
|
@Outurnate You can click the Linux error: |
|
@JackBoosY upstream has declined to apply the patch. The CMake files generated by GENie don't link shaderc & friends to libdl. According to the maintainer of bgfx and vcpkg, CMake generation isn't supported (ref bgfx#1958) Appreciate the pointer to the detailed logs. Since this change represents a total rewrite, I'll be closing this PR and resubmitting |
This is a resubmit of #7763 with some changes