Skip to content

[libical] Add new port#8754

Closed
winterz wants to merge 6 commits intomicrosoft:masterfrom
winterz:master
Closed

[libical] Add new port#8754
winterz wants to merge 6 commits intomicrosoft:masterfrom
winterz:master

Conversation

@winterz
Copy link
Copy Markdown

@winterz winterz commented Oct 26, 2019

This is a new port for the libical project and also my first ever attempt to create a vcpkg port.

@msftclas
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ winterz sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@PhoebeHui PhoebeHui requested a review from NancyLi1013 October 29, 2019 02:18
Comment thread ports/libical/portfile.cmake Outdated
Comment thread ports/libical/portfile.cmake Outdated
Comment thread ports/libical/portfile.cmake
Comment thread ports/libical/portfile.cmake Outdated
Comment thread ports/libical/portfile.cmake Outdated
@NancyLi1013
Copy link
Copy Markdown
Contributor

Hi @winterz thanks for this pull request. Please try to sign CLA first. You can click the following link to complete it.
https://cla.opensource.microsoft.com/microsoft/vcpkg?pullRequest=8754

@winterz
Copy link
Copy Markdown
Author

winterz commented Nov 1, 2019

I will update the pull request as indicated.

as for signing the CLA: my employer is ok with my signing it, but they are deciding on a company-wide policy. might take some time.

@grdowns grdowns self-assigned this Nov 18, 2019
@JackBoosY
Copy link
Copy Markdown
Contributor

/azp run

@winterz
Copy link
Copy Markdown
Author

winterz commented Nov 19, 2019

same to you bub :)
I'm not sure what you're referring to @JackBoosY

@JackBoosY
Copy link
Copy Markdown
Contributor

@winterz I just restart the CI test.

@NancyLi1013
Copy link
Copy Markdown
Contributor

@winterz
I also noticed that you have added these two ports qt5-kdreports and qt5-kdsoap in this PR.
Could you add them in a separate PR? Please refer to this doc.

As qt5-kdreports and qt5-kdsoap belong to qt5. You can refer to other qt5 components to add them.
So please remove these two ports from this PR.

@JackBoosY
Copy link
Copy Markdown
Contributor

/azp run

@NancyLi1013 NancyLi1013 changed the title Add libical port [libical] Add new port Dec 13, 2019
@NancyLi1013 NancyLi1013 self-assigned this Dec 17, 2019
@winterz
Copy link
Copy Markdown
Author

winterz commented Dec 18, 2019

I'm going to abandon this for now.

@winterz winterz closed this Dec 18, 2019
@wrobelda
Copy link
Copy Markdown
Contributor

@winterz any particular reason why you abandoned this?

@wrobelda
Copy link
Copy Markdown
Contributor

FYI, I built a new PR on top of yours here: #20965

@wrobelda wrobelda mentioned this pull request Oct 24, 2021
1 task
@winterz
Copy link
Copy Markdown
Author

winterz commented Oct 25, 2021

@winterz any particular reason why you abandoned this?
not really. probably forgot about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants