Conversation
There was a problem hiding this comment.
That would require an additional dependency of Glib and LibXml2. I was thinking about making it a separate feature, but based on your readme1, it seems very experimental, so I gave up on it. I can try adding that feature, after all, but first need to fix the icu issue.
Footnotes
-
The libical-glib API is currently unstable and can change with any release. Until it is considered stable, there should be defined LIBICAL_GLIB_UNSTABLE_API=1 before including <libical-glib/libical-glib.h>, to indicate that the library user is aware of it and is prepared to change the calls anytime. (https://github.com/libical/libical#introduction) ↩
There was a problem hiding this comment.
@winterz tried adding "glib" feature, but getting:
CMake Error:
Running
'/Users/cromo/Documents/Sourcecode/vcpkg/downloads/tools/ninja-1.10.2-osx/ninja' '-C' '/Users/cromo/Documents/Sourcecode/vcpkg/buildtrees/libical/arm64-osx-dbg' '-t' 'recompact'
failed with:
ninja: error: build.ninja:2151: multiple rules generate lib/libical-glib.a [-w dupbuild=err]
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/libical/vcpkg.json b/ports/libical/vcpkg.json
index 9eb1ba3..7ff86fb 100644
--- a/ports/libical/vcpkg.json
+++ b/ports/libical/vcpkg.json
@@ -16,10 +16,10 @@
"features": {
"rscale": {
"description": "Support for RSCALE element",
+ "supports": "!static",
"dependencies": [
"icu"
- ],
- "supports": "!static"
+ ]
}
}
}PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for libical but no changes to version or port version.
-- Version: 3.0.11
-- Old SHA: 07874cb9f7940f73738bcd1d66eff755aefbc306
-- New SHA: f4ab3492c90b3d683702cacb90aaea839cfc3d8f
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
|
@PhoebeHui this is ready to build now. I restricted the |
Describe the pull request
Adds new LibIcal library. Builds on top of #8754
Depends on:
[icu] static build consumption failure on macOS and Linux #20966
Which triplets are supported/not supported? Have you updated the CI baseline?
All official, plus
arm64-osxDoes your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes