Skip to content

[poco] Fix the release libraries are linked to debug pcred.dll#7099

Closed
tetsuh wants to merge 2 commits intomicrosoft:masterfrom
tetsuh:poco-fix-pcred-link
Closed

[poco] Fix the release libraries are linked to debug pcred.dll#7099
tetsuh wants to merge 2 commits intomicrosoft:masterfrom
tetsuh:poco-fix-pcred-link

Conversation

@tetsuh
Copy link
Contributor

@tetsuh tetsuh commented Jun 30, 2019

This merge fixies #6349 but adhoc way.

This is a modified version of PR #5994 to support non-windows platforms.

Note: this find_pcre.patch will be breaked by POCO's upstream modification pocoproject/poco@bd98f5c
So we will need to remake find_pcre.patch when bump up ports/poco/portfile.cmake.

Usually, this problem should be solved by POCO or PCRE itself by providing FindPCRE.cmake.
In the meantime, I would like to apply this patch to keep the correct POCO build on vcpkg.

Initially, #5543 considered to include #5994 but finally excluded. because it looks a special kind of butterfly between #304 and #5994. I hope this fixes these butterfly issue too.

@tetsuh tetsuh changed the title [poco] Fixed the release libraries are linked to debug pcred.dll [poco] Fix the release libraries are linked to debug pcred.dll Jun 30, 2019
using CMAKE_DEBUG_POSTFIX doesn't work for the other platforms.
@cbezault
Copy link
Contributor

cbezault commented Jul 9, 2019

I think this can be implemented in a vcpkg-wrapper. Take a look at scripts/buildsystems/vcpkg.cmake. We intercept all calls to find_package and replace it with a macro.

Also see #7203

@tetsuh
Copy link
Contributor Author

tetsuh commented Jul 10, 2019

Thnx. I try vcpkg-wrapper.

@JackBoosY
Copy link
Contributor

@tetsuh I think #7698 would be better.

@tetsuh
Copy link
Contributor Author

tetsuh commented Aug 15, 2019

@JackBoosY Yes, #7698 is better way that use select_library_configurations ().

@tetsuh
Copy link
Contributor Author

tetsuh commented Aug 15, 2019

@cbezault I've tried putting ports/pcre/vcpkg-cmake-wrapper.cmake and I saw how it working to override find_package(pcre). then, I thought that it would be better to put pcre-config.cmake because that would allow find_package(pcre) other than vcpkg.
Anyway, at the moment I couldn't reach a good solution.

@tetsuh tetsuh closed this Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants