[poco] Fix the release libraries are linked to debug pcred.dll#7099
Closed
tetsuh wants to merge 2 commits intomicrosoft:masterfrom
Closed
[poco] Fix the release libraries are linked to debug pcred.dll#7099tetsuh wants to merge 2 commits intomicrosoft:masterfrom
tetsuh wants to merge 2 commits intomicrosoft:masterfrom
Conversation
using CMAKE_DEBUG_POSTFIX doesn't work for the other platforms.
Contributor
|
I think this can be implemented in a vcpkg-wrapper. Take a look at scripts/buildsystems/vcpkg.cmake. We intercept all calls to find_package and replace it with a macro. Also see #7203 |
Contributor
Author
|
Thnx. I try vcpkg-wrapper. |
Contributor
Contributor
Author
|
@JackBoosY Yes, #7698 is better way that use select_library_configurations (). |
Contributor
Author
|
@cbezault I've tried putting ports/pcre/vcpkg-cmake-wrapper.cmake and I saw how it working to override find_package(pcre). then, I thought that it would be better to put pcre-config.cmake because that would allow find_package(pcre) other than vcpkg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge fixies #6349 but adhoc way.
This is a modified version of PR #5994 to support non-windows platforms.
Note: this find_pcre.patch will be breaked by POCO's upstream modification pocoproject/poco@bd98f5c
So we will need to remake find_pcre.patch when bump up ports/poco/portfile.cmake.
Usually, this problem should be solved by POCO or PCRE itself by providing FindPCRE.cmake.
In the meantime, I would like to apply this patch to keep the correct POCO build on vcpkg.
Initially, #5543 considered to include #5994 but finally excluded. because it looks a special kind of butterfly between #304 and #5994. I hope this fixes these butterfly issue too.