[poco] fix pcre linking against pcred on release#5994
[poco] fix pcre linking against pcred on release#5994angelmixu wants to merge 1 commit intomicrosoft:masterfrom
Conversation
|
Hi @angelmixu , here are the test results from the current CI system, please let me know if you need the logs.
At the same time, could you also update the CONTROL version? |
|
@NancyLi1013 hi! How strange, in my macOS was building correctly :/ |
|
@Rastaban , could you help provide MacOS logs? |
|
will be solved by #5543 |
|
@NancyLi1013 sorry, I just cleaned installed poco on my mac and now I can see the error! should I change the patch on poco for only looking for the 'd' suffix on windows, or should I change pcre for putting always a 'd' suffix on debug builds? |
|
I am in strong favor of not adding d suffixes if find_package does not support it! see discussion in #5543 |
|
Read it, looks quite good! |
|
hmm the pcre problem is a bit bigger since it is not handled equally in all ports.... |
|
@Neumann-A since your PR #5543 fixes the bug I was trying to fix, I'll close this PR. |
Latest version of poco was linking on releas against the debug binary of pcre.
So, PocoFoundation.dll was looking for pcred.dll.