Skip to content

[poco] fix pcre linking against pcred on release#5994

Closed
angelmixu wants to merge 1 commit intomicrosoft:masterfrom
angelmixu:_poco_fix_pcre_linkage
Closed

[poco] fix pcre linking against pcred on release#5994
angelmixu wants to merge 1 commit intomicrosoft:masterfrom
angelmixu:_poco_fix_pcre_linkage

Conversation

@angelmixu
Copy link
Contributor

Latest version of poco was linking on releas against the debug binary of pcre.
So, PocoFoundation.dll was looking for pcred.dll.

@NancyLi1013
Copy link
Contributor

Hi @angelmixu , here are the test results from the current CI system, please let me know if you need the logs.

x64-osx master test notes
poco Pass Fail Regression
x64-linux master test notes
poco Pass Fail Regression

At the same time, could you also update the CONTROL version?

@angelmixu
Copy link
Contributor Author

@NancyLi1013 hi! How strange, in my macOS was building correctly :/
Sure, if you can post the logs it would help, thanks!

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 9, 2019

@Rastaban , could you help provide MacOS logs?
Thanks.

@Neumann-A
Copy link
Contributor

will be solved by #5543

@angelmixu
Copy link
Contributor Author

@NancyLi1013 sorry, I just cleaned installed poco on my mac and now I can see the error!
Looks like libpcre has no 'd' suffix on macOS, in the CMakeLists.txt from pcre there's this:

IF(WIN32)
  SET(CMAKE_DEBUG_POSTFIX "d")
ENDIF(WIN32)

should I change the patch on poco for only looking for the 'd' suffix on windows, or should I change pcre for putting always a 'd' suffix on debug builds?

@Neumann-A
Copy link
Contributor

I am in strong favor of not adding d suffixes if find_package does not support it! see discussion in #5543

@angelmixu
Copy link
Contributor Author

Read it, looks quite good!
Now I don't know how to continue with this :_D

@Neumann-A
Copy link
Contributor

hmm the pcre problem is a bit bigger since it is not handled equally in all ports....

@angelmixu
Copy link
Contributor Author

@Neumann-A since your PR #5543 fixes the bug I was trying to fix, I'll close this PR.
Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants