Skip to content

[spirv-tools] Add cmake targets#5577

Merged
grdowns merged 3 commits intomicrosoft:masterfrom
cwfitzgerald:spirv-tools-target
Mar 15, 2019
Merged

[spirv-tools] Add cmake targets#5577
grdowns merged 3 commits intomicrosoft:masterfrom
cwfitzgerald:spirv-tools-target

Conversation

@cwfitzgerald
Copy link
Contributor

@cwfitzgerald cwfitzgerald commented Mar 7, 2019

This PR adds a patch to spirv-tools to give it cmake targets to import.

Notes:

  • There was an extra shared library that was being built at the same time as the static we thought we were getting. I have disabled this for now. However, that means we could possibly reopen spirv-tools to being built as both a static and dynamic library through another patch, however that is outside the scope of this PR.
  • Because of change I made above, it would be basically impossible to merge this into upstream as it would change their defaults in their build system and I would have to justify such a breaking change.

@grdowns grdowns self-assigned this Mar 7, 2019
@PhoebeHui
Copy link
Contributor

@cwfitzgerald, thanks for contributing to vcpkg! All triplets build successfully.

@grdowns
Copy link
Contributor

grdowns commented Mar 15, 2019

Good catch. Thanks for the PR, @cwfitzgerald!

@grdowns grdowns merged commit 5afc345 into microsoft:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants