Merged
Conversation
cwfitzgerald
requested changes
Mar 7, 2019
Member
cwfitzgerald
left a comment
cwfitzgerald
left a comment
There was a problem hiding this comment.
Almost done, I think we just need to unfuck appveyor and jenkins once the final PR to vcpkg gets cleared
cwfitzgerald
previously approved these changes
Mar 7, 2019
Member
Author
|
CI can't build this PR until microsoft/vcpkg#5577 is merged |
Member
Author
|
test this please |
1 similar comment
Member
Author
|
test this please |
Member
|
Merging blocked until microsoft/vcpkg#5699 merged. |
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
========================================
Coverage ? 6.74%
========================================
Files ? 51
Lines ? 3515
Branches ? 0
========================================
Hits ? 237
Misses ? 3278
Partials ? 0
Continue to review full report at Codecov.
|
cwfitzgerald
approved these changes
Mar 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.