[capstone] Update Capstone to v4.0.1-49-ge3d5a594#5546
Merged
Rastaban merged 5 commits intomicrosoft:masterfrom Mar 15, 2019
Merged
[capstone] Update Capstone to v4.0.1-49-ge3d5a594#5546Rastaban merged 5 commits intomicrosoft:masterfrom
Rastaban merged 5 commits intomicrosoft:masterfrom
Conversation
|
|
Contributor
|
It looks like there are new build breaks on the UWP triplets on windows. Would you be able to look into those? |
Rastaban
changed the title
Rastaban
reviewed
Mar 5, 2019
ports/capstone/portfile.cmake
Outdated
Contributor
There was a problem hiding this comment.
Could you use the full sha here?
Contributor
Author
|
The failing UWP build is caused by a bug in upstream Capstone; capstone-engine/capstone#1421 should fix this. I'll wait for the upstream PR to be merged and then update straight to the newest v4 branch once the PR is merged. |
Contributor
|
Sounds good, I will watch for your update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I opted to base the package on commit e3d5a594 (latest v4 branch as of today) rather than v4.0.1 because v4.0.1 does not build successfully with x86_reduce enabled.
This PR also adds support for selectively enabling architecture support and/or diet mode.
Fixes #5276.