Fix #1420: Capstone 4 fails to build when targeting UWP#1421
Merged
aquynh merged 1 commit intocapstone-engine:v4from Mar 14, 2019
Merged
Fix #1420: Capstone 4 fails to build when targeting UWP#1421aquynh merged 1 commit intocapstone-engine:v4from
aquynh merged 1 commit intocapstone-engine:v4from
Conversation
Contributor
|
IMO defining strcpy as strcpy_s under MSVC would be better ? |
Collaborator
|
@fotisl please ack. |
Collaborator
|
alternatively, we can also put this in source code, like https://github.com/aquynh/capstone/blob/master/arch/M68K/M68KInstPrinter.c#L4-L8 ? |
Contributor
Author
|
There is also https://github.com/aquynh/capstone/blob/master/arch/Sparc/SparcInstPrinter.c#L19-L25 so at least it is consistent to put the define into TMS320C64xInstPrinter.c . I amended the last commit. |
Collaborator
|
@fotisl, i will just merge this simple fix. thanks! |
aquynh
pushed a commit
that referenced
this pull request
Mar 14, 2019
aquynh
pushed a commit
that referenced
this pull request
Mar 14, 2019
Contributor
|
@aquynh Yes, it's a simple fix, it's good that it's merged. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.